fix: remove repository link display on missing param errors (anuraghazra#4560)

* fix: remove repository link display on missing param errors

* fix tests

---------

Co-authored-by: Alexandr <qwerty541zxc@gmail.com>

Author: opheliagoldstein

api/gist.js

@@ -11,7 +11,10 @@ import {
   setErrorCacheHeaders,
 } from "../src/common/cache.js";
 import { guardAccess } from "../src/common/access.js";
-import { retrieveSecondaryMessage } from "../src/common/error.js";
+import {
+  MissingParamError,
+  retrieveSecondaryMessage,
+} from "../src/common/error.js";
 
 // @ts-ignore
 export default async (req, res) => {
@@ -102,6 +105,7 @@ export default async (req, res) => {
             bg_color,
             border_color,
             theme,
+            show_repo_link: !(err instanceof MissingParamError),
           },
         }),
       );

api/index.js

@@ -8,7 +8,10 @@ import {
   setCacheHeaders,
   setErrorCacheHeaders,
 } from "../src/common/cache.js";
-import { retrieveSecondaryMessage } from "../src/common/error.js";
+import {
+  MissingParamError,
+  retrieveSecondaryMessage,
+} from "../src/common/error.js";
 import { parseArray, parseBoolean, renderError } from "../src/common/utils.js";
 import { fetchStats } from "../src/fetchers/stats.js";
 import { isLocaleAvailable } from "../src/translations.js";
@@ -140,6 +143,7 @@ export default async (req, res) => {
             bg_color,
             border_color,
             theme,
+            show_repo_link: !(err instanceof MissingParamError),
           },
         }),
       );

api/pin.js

@@ -8,7 +8,10 @@ import {
   setCacheHeaders,
   setErrorCacheHeaders,
 } from "../src/common/cache.js";
-import { retrieveSecondaryMessage } from "../src/common/error.js";
+import {
+  MissingParamError,
+  retrieveSecondaryMessage,
+} from "../src/common/error.js";
 import { parseBoolean, renderError } from "../src/common/utils.js";
 import { fetchRepo } from "../src/fetchers/repo.js";
 import { isLocaleAvailable } from "../src/translations.js";
@@ -105,6 +108,7 @@ export default async (req, res) => {
             bg_color,
             border_color,
             theme,
+            show_repo_link: !(err instanceof MissingParamError),
           },
         }),
       );

api/top-langs.js

@@ -8,7 +8,10 @@ import {
   setCacheHeaders,
   setErrorCacheHeaders,
 } from "../src/common/cache.js";
-import { retrieveSecondaryMessage } from "../src/common/error.js";
+import {
+  MissingParamError,
+  retrieveSecondaryMessage,
+} from "../src/common/error.js";
 import { parseArray, parseBoolean, renderError } from "../src/common/utils.js";
 import { fetchTopLanguages } from "../src/fetchers/top-languages.js";
 import { isLocaleAvailable } from "../src/translations.js";
@@ -163,6 +166,7 @@ export default async (req, res) => {
             bg_color,
             border_color,
             theme,
+            show_repo_link: !(err instanceof MissingParamError),
           },
         }),
       );

api/wakatime.js

@@ -11,7 +11,10 @@ import {
   setErrorCacheHeaders,
 } from "../src/common/cache.js";
 import { guardAccess } from "../src/common/access.js";
-import { retrieveSecondaryMessage } from "../src/common/error.js";
+import {
+  MissingParamError,
+  retrieveSecondaryMessage,
+} from "../src/common/error.js";
 
 // @ts-ignore
 export default async (req, res) => {
@@ -121,6 +124,7 @@ export default async (req, res) => {
             bg_color,
             border_color,
             theme,
+            show_repo_link: !(err instanceof MissingParamError),
           },
         }),
       );

tests/gist.test.js

@@ -129,6 +129,7 @@ describe("Test /api/gist", () => {
       renderError({
         message: 'Missing params "id" make sure you pass the parameters in URL',
         secondaryMessage: "/api/gist?id=GIST_ID",
+        renderOptions: { show_repo_link: false },
       }),
     );
   });

tests/pin.test.js

@@ -212,6 +212,7 @@ describe("Test /api/pin", () => {
         message:
           'Missing params "username", "repo" make sure you pass the parameters in URL',
         secondaryMessage: "/api/pin?username=USERNAME&repo=REPO_NAME",
+        renderOptions: { show_repo_link: false },
       }),
     );
   });