Merge pull request #757 from MLB-LED-Scoreboard/dev

Release v9.1.4

Author: ty-porter

README.md

@@ -36,6 +36,7 @@ If you'd like to see support for another set of board dimensions, or have design
 - [Features](#features)
   * [Live Games](#live-games)
   * [Pregame](#pregame)
+  * [Editorial Blurbs](#editorial-blurbs)
   * [Division Standings](#division-standings)
 - [Installation](#installation)
   * [Hardware Assembly](#hardware-assembly)
@@ -98,6 +99,15 @@ If a game hasn't started yet, a pregame screen will be displayed with the probab
 <a href="assets/img/128x64.png">
   <img alt="Astros-Athletics pregame" width="auto" height="200" src="assets/img/128x64.png"></a>
 
+### Editorial Blurbs
+The scoreboard pulls the MLB.com editorial blurb (`headline — subhead`) from the `game_content` endpoint and appends it to the scrolling text on the pregame and postgame screens.
+
+**Recap** blurbs appear on Final games and are usually published within ~30 minutes of the last out — most games get one.
+
+**Preview** blurbs are wired up the same way, but MLB only rarely publishes editorial previews for regular-season games. Expect them mostly on playoff or nationally-broadcast matchups; the feature stays silent the rest of the time.
+
+The behavior can be turned off by setting `editorial_blurb` to `false` in your `config.json`.
+
 ### Division Standings
 It can display standings for the provided division. Since the 32x32 board is too small to display wins and losses together, the wins and losses are alternated on the board every 5 seconds. You can also specify "NL Wild Card" or "AL Wild Card" as a 'division' to see the top 5 teams in each league's wild card race.
 
@@ -289,6 +299,7 @@ See [`config.schema.json`](config.schema.json) for a schema for configuration fi
 "scrolling_speed"                 Integer Sets how fast the scrolling text scrolls. Supports an integer between 0 and 6.
 "sync_delay_seconds"              Integer Delays game updates to sychronize with broadcasts. May introduce delay before rendering live games. Must be at least 0, defaults to 0 (no delay).
 "api_refresh_rate"                Integer Refresh the game data from the MLB API every X seconds. Must be at least 3, default is 10.
+"editorial_blurb"                 Bool    Append the MLB.com editorial blurb (headline + subhead) to the scrolling text on pregame and postgame screens. Recaps are routinely published; previews are rare. See the Editorial Blurbs feature section.
 "debug"                           Bool    Game and other debug data is written to your console.
 "demo_date"                       String  A date in the format YYYY-MM-DD from which to pull data to demonstrate the scoreboard. A value of `false` will disable demo mode.
 ```

data/__init__.py

@@ -34,9 +34,7 @@ def refresh_plugin(self, name: str) -> None:
         status = UpdateStatus.FAIL
         try:
             status = plugin.update()
-        except KeyboardInterrupt as e:
-            raise e
-        except:
+        except Exception:
             LOGGER.exception("Failure while updating plugin %s", name)
 
         self.__process_network_status(status)

data/config/__init__.py

@@ -151,7 +151,7 @@ def check_rotate_rates(self):
                 # Try and cast whatever the user passed into a float
                 rate = float(value)
                 self.rotation_rates[key] = rate
-            except:
+            except Exception:
                 # Use the default rotate rate if it fails
                 LOGGER.warning(
                     'Unable to convert rotate_rates["{}"] to a Float. Using default value. ({})'.format(

data/config/layout.py

@@ -47,9 +47,7 @@ def font(self, keypath):
         """
         try:
             return self.__get_font_object(self.coords(keypath)[FONTNAME_KEY])
-        except KeyboardInterrupt as e:
-            raise e
-        except:
+        except Exception:
             return self.__get_font_object(self.default_font_name)
 
     def coords(self, keypath):

data/game.py

@@ -90,7 +90,7 @@ def update(self, force=False, testing_params={}) -> UpdateStatus:
                         self._status = next(
                             g["games"][0]["status"] for g in scheduled["dates"] if g["date"] == self.date
                         )
-                    except:
+                    except Exception:
                         LOGGER.error("Failed to get game status from schedule")
                 else:
                     self._status = self._current_data["gameData"]["status"]
@@ -99,7 +99,7 @@ def update(self, force=False, testing_params={}) -> UpdateStatus:
                 self._blurb_data.update()
                 self.print_game_data_debug()
                 return UpdateStatus.SUCCESS
-            except:
+            except Exception:
                 LOGGER.exception("Networking Error while refreshing the current game data.")
                 return UpdateStatus.FAIL
         return UpdateStatus.DEFERRED
@@ -246,54 +246,54 @@ def pitcher_stat(self, player, stat, team=None):
                 stats = self._current_data["liveData"]["boxscore"]["teams"]["home"]["players"][ID]["seasonStats"][
                     "pitching"
                 ]
-            except:
+            except Exception:
                 try:
                     stats = self._current_data["liveData"]["boxscore"]["teams"]["away"]["players"][ID]["seasonStats"][
                         "pitching"
                     ]
-                except:
+                except Exception:
                     return ""
 
         return stats[stat]
 
     def probable_pitcher_id(self, team):
         try:
             return self._current_data["gameData"]["probablePitchers"][team]["id"]
-        except:
+        except Exception:
             return None
 
     def decision_pitcher_id(self, decision):
         try:
             return self._current_data["liveData"]["decisions"][decision]["id"]
-        except:
+        except Exception:
             return None
 
     def batter(self):
         try:
             batter_id = self._current_data["liveData"]["linescore"]["offense"]["batter"]["id"]
             return self.boxscore_name(batter_id)
-        except:
+        except Exception:
             return ""
 
     def in_hole(self):
         try:
             batter_id = self._current_data["liveData"]["linescore"]["offense"]["inHole"]["id"]
             return self.boxscore_name(batter_id)
-        except:
+        except Exception:
             return ""
 
     def on_deck(self):
         try:
             batter_id = self._current_data["liveData"]["linescore"]["offense"]["onDeck"]["id"]
             return self.boxscore_name(batter_id)
-        except:
+        except Exception:
             return ""
 
     def pitcher(self):
         try:
             pitcher_id = self._current_data["liveData"]["linescore"]["defense"]["pitcher"]["id"]
             return self.boxscore_name(pitcher_id)
-        except:
+        except Exception:
             return ""
 
     def balls(self):
@@ -314,7 +314,7 @@ def last_pitch(self):
                     play["details"]["type"]["code"],
                     play["details"]["type"]["description"],
                 )
-        except:
+        except Exception:
             return None
 
     def current_pitcher_pitch_count(self):
@@ -325,26 +325,26 @@ def current_pitcher_pitch_count(self):
                 return self._current_data["liveData"]["boxscore"]["teams"]["away"]["players"][ID]["stats"]["pitching"][
                     "numberOfPitches"
                 ]
-            except:
+            except Exception:
                 return self._current_data["liveData"]["boxscore"]["teams"]["home"]["players"][ID]["stats"]["pitching"][
                     "numberOfPitches"
                 ]
-        except:
+        except Exception:
             return 0
 
     def note(self):
         try:
             return self._current_data["liveData"]["linescore"]["note"]
-        except:
+        except Exception:
             return None
 
     def reason(self):
         try:
             return self._status["reason"]
-        except:
+        except Exception:
             try:
                 return self._status["detailedState"].split(":")[1].strip()
-            except:
+            except Exception:
                 return None
 
     def broadcasts(self):

data/schedule.py

@@ -38,7 +38,7 @@ def update(self, force=False) -> UpdateStatus:
             try:
                 # add sportId=51 to additionally get WBC games
                 all_games = statsapi.schedule(self.date.strftime("%Y-%m-%d"), sportId="1,51")
-            except:
+            except Exception:
                 LOGGER.exception("Networking error while refreshing schedule")
                 return UpdateStatus.FAIL
             else:

data/scoreboard/postgame.py

@@ -24,7 +24,7 @@ def __init__(self, game: "Game"):
                 self.winning_pitcher = game.full_name(winner)
                 self.winning_pitcher_wins = game.pitcher_stat(winner, "wins", winner_side)
                 self.winning_pitcher_losses = game.pitcher_stat(winner, "losses", winner_side)
-            except:
+            except Exception:
                 LOGGER.exception("Error getting winning pitcher stats")
 
         self.save_pitcher = None
@@ -35,7 +35,7 @@ def __init__(self, game: "Game"):
             try:
                 self.save_pitcher = game.full_name(save)
                 self.save_pitcher_saves = game.pitcher_stat(save, "saves", winner_side)
-            except:
+            except Exception:
                 LOGGER.exception("Error getting save pitcher stats")
 
         self.losing_pitcher = PITCHER_UNKNOWN
@@ -48,7 +48,7 @@ def __init__(self, game: "Game"):
                 self.losing_pitcher = game.full_name(loser)
                 self.losing_pitcher_wins = game.pitcher_stat(loser, "wins", loser_side)
                 self.losing_pitcher_losses = game.pitcher_stat(loser, "losses", loser_side)
-            except:
+            except Exception:
                 LOGGER.exception("Error getting losing pitcher stats")
 
         self.series_status = game.series_status()

data/scoreboard/pregame.py

@@ -20,7 +20,7 @@ def __init__(self, game: "Game", time_format):
 
         try:
             self.start_time = self.__convert_time(game.datetime())
-        except:
+        except Exception:
             self.start_time = "TBD"
 
         self.status = game.status()
@@ -34,7 +34,7 @@ def __init__(self, game: "Game", time_format):
                 losses = game.pitcher_stat(away_id, "losses", "away")
                 era = game.pitcher_stat(away_id, "era", "away")
                 self.away_starter = "{} ({}-{} {} ERA)".format(name, wins, losses, era)
-            except:
+            except Exception:
                 LOGGER.exception("Error getting away starter stats")
 
         self.home_starter = PITCHER_TBD
@@ -46,7 +46,7 @@ def __init__(self, game: "Game", time_format):
                 losses = game.pitcher_stat(home_id, "losses", "home")
                 era = game.pitcher_stat(home_id, "era", "home")
                 self.home_starter = "{} ({}-{} {} ERA)".format(name, wins, losses, era)
-            except:
+            except Exception:
                 LOGGER.exception("Error getting away starter stats")
 
         self.national_broadcasts = game.broadcasts()

main.py

@@ -108,7 +108,7 @@ def __render_main(matrix, data, plugins):
 
     try:
         main(matrix, config)
-    except:
+    except Exception:
         LOGGER.exception("Untrapped error in main!")
         sys.exit(1)
     finally:

news/src/mlb_led_scoreboard_news/dates.py

@@ -16,7 +16,7 @@ def __init__(self, dates, today: date):
             if year == now.year and end_date < now:
                 data_d = statsapi.get("season", {"sportId": 1, "seasonId": year + 1})
                 self.__parse_important_dates(data_d["seasons"][0], year + 1)
-        except:
+        except Exception:
             LOGGER.exception("Failed to refresh important dates")
             self.important_dates = [{"text": "None", "date": datetime(3000, 1, 1), "max_days": 1}]
         try:
@@ -25,7 +25,7 @@ def __init__(self, dates, today: date):
                 if d.count("-") == 1:
                     d = f"{year}-{d}"
                 self.__add_date(d, date["text"], date.get("max_days", 365))
-        except:
+        except Exception:
             LOGGER.exception("Failed to parse important dates from config")
 
         LOGGER.debug("Important dates: %s", self.important_dates)