fix: update plugins which are detected as out of sync

hbagdi · web-flow · commit de9e38c6a4c8 · 2018-09-21T13:24:22.000-07:00
This is regression introduced in 2550758. The plugins were being detected out of sync but not actually synced to Kong. No tests are added currently since this is due a refactor soon. From #138
diff --git a/internal/ingress/controller/kong.go b/internal/ingress/controller/kong.go
@@ -497,6 +497,7 @@ func (n *NGINXController) syncServices(ingressCfg *ingress.Configuration) (bool,
 							}
 							p.Consumer = fmt.Sprintf("%v", consumer.GetUID())
 						}
+						pluginsToUpdate = append(pluginsToUpdate, p)
 					}
 				}
 			}
@@ -908,6 +909,7 @@ func (n *NGINXController) syncRoutes(ingressCfg *ingress.Configuration) (bool, e
 							}
 							p.Consumer = fmt.Sprintf("%v", consumer.GetUID())
 						}
+						pluginsToUpdate = append(pluginsToUpdate, p)
 					}
 					glog.Infof("plugin %v configuration in kong is up to date.", pluginInk8s.PluginName)
 

Original file line number	Diff line number	Diff line change
`@@ -497,6 +497,7 @@ func (n NGINXController) syncServices(ingressCfg ingress.Configuration) (bool,`
`497`	`497`	`}`
`498`	`498`	`p.Consumer = fmt.Sprintf("%v", consumer.GetUID())`
`499`	`499`	`}`
	`500`	`+ pluginsToUpdate = append(pluginsToUpdate, p)`
`500`	`501`	`}`
`501`	`502`	`}`
`502`	`503`	`}`
`@@ -908,6 +909,7 @@ func (n NGINXController) syncRoutes(ingressCfg ingress.Configuration) (bool, e`
`908`	`909`	`}`
`909`	`910`	`p.Consumer = fmt.Sprintf("%v", consumer.GetUID())`
`910`	`911`	`}`
	`912`	`+ pluginsToUpdate = append(pluginsToUpdate, p)`
`911`	`913`	`}`
`912`	`914`	`glog.Infof("plugin %v configuration in kong is up to date.", pluginInk8s.PluginName)`
`913`	`915`