Merge bitcoin/bitcoin#35869: lint: (re-)add contrib/guix for Python linting

8221d714c7888cbcf44971ab279effde505707a9 lint: document CI lief version requirement (fanquake)
594a02c3ae05ae4985f6647c7ffb94d615b7a8a1 lint: re-add guix scripts to mypy linting (fanquake)

Pull request description:

  These were no-longer being linted after bitcoin/bitcoin#32458.

  suppress `[union-attr]` warning. i.e:
  ```bash
  contrib/guix/symbol-check.py:309: error: Item "None" of "lief.PE.Binary | lief.ELF.Binary | lief.MachO.Binary | lief.COFF.Binary | None" has no attribute "format"  [union-attr]
  contrib/guix/security-check.py:284: error: Item "lief.COFF.Binary" of "lief.PE.Binary | lief.ELF.Binary | lief.MachO.Binary | lief.COFF.Binary | None" has no attribute "abstract"  [union-attr]
  ```

  Add the comment suggested in [#35855.](bitcoin/bitcoin#35855 (comment)).

ACKs for top commit:
  maflcko:
    lgtm ACK 8221d714c7888cbcf44971ab279effde505707a9 in any case.
  hebasto:
    ACK 8221d714c7888cbcf44971ab279effde505707a9, I have reviewed the code and it looks OK.

Tree-SHA512: ec404a8235fd40b212aad71ee3fe3473a3ce6f1ebaed46661d36ef02862b08528e3b6b829e05c5b943c8543380f3876e33da725154ce31d4022ad39ae5ef5ab3

Author: fanquake

ci/lint/requirements.txt

@@ -1,3 +1,4 @@
+# lief version should match the version used in Guix
 lief==0.17.5
 mypy==2.3.0
 pyzmq==27.1.0

contrib/guix/security-check.py

@@ -280,8 +280,8 @@ def check_MACHO_BRANCH_PROTECTION(binary) -> bool:
     for filename in sys.argv[1:]:
         binary = lief.parse(filename)
 
-        etype = binary.format
-        arch = binary.abstract.header.architecture
+        etype = binary.format # type: ignore[union-attr]
+        arch = binary.abstract.header.architecture # type: ignore[union-attr]
 
         failed: list[str] = []
         for (name, func) in CHECKS[etype][arch]:

contrib/guix/symbol-check.py

@@ -306,7 +306,7 @@ def check_ELF_ABI(binary) -> bool:
     for filename in sys.argv[1:]:
         binary = lief.parse(filename)
 
-        etype = binary.format
+        etype = binary.format # type: ignore[union-attr]
 
         failed: list[str] = []
         for (name, func) in CHECKS[etype]:

test/lint/lint-python.py

@@ -20,9 +20,9 @@
 
 DEPS = ['lief', 'mypy', 'pyzmq']
 
-# Only .py files in test/functional and contrib/devtools have type annotations
+# Only .py files in test/functional and contrib/(devtools|guix) have type annotations
 # enforced.
-MYPY_FILES_ARGS = ['git', 'ls-files', 'test/functional/*.py', 'contrib/devtools/*.py']
+MYPY_FILES_ARGS = ['git', 'ls-files', 'test/functional/*.py', 'contrib/devtools/*.py', 'contrib/guix/*.py']
 
 
 def check_dependencies():