Merge pull request #248 from GunnarFarneback/write_empty_key

kescobo · web-flow · commit 67e60e6585db · 2025-11-04T11:10:37.000-05:00
Support writing of empty string keys
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "YAML"
 uuid = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6"
-version = "0.4.14"
+version = "0.4.15"
 
 
 [deps]
diff --git a/src/writer.jl b/src/writer.jl
@@ -74,7 +74,7 @@ function _print(io::IO, pair::Pair, level::Int=0, ignore_level::Bool=false)
     key = if pair[1] === nothing
         "null" # this is what the YAML parser interprets as 'nothing'
     elseif pair[1] isa AbstractString && (
-        occursin('#', pair[1]) || first(pair[1]) in "{}[]&*?|-<>=!%@:`,\"'"
+        isempty(pair[1]) || occursin('#', pair[1]) || first(pair[1]) in "{}[]&*?|-<>=!%@:`,\"'"
     )
         string("\"", escape_string(pair[1]), "\"") # special keys that require quoting
     else
diff --git a/test/julia/empty_key.jl b/test/julia/empty_key.jl
@@ -0,0 +1 @@
+Dict("" => "")
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -50,6 +50,7 @@ const tests = [
     "utf-32-be",
     "empty_tag",
     "empty_list_elem",
+    "empty_key",
 ]
 
 # ignore some test cases in write_and_load testing
diff --git a/test/yaml/empty_key.yaml b/test/yaml/empty_key.yaml
@@ -0,0 +1 @@
+"": ""

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ function _print(io::IO, pair::Pair, level::Int=0, ignore_level::Bool=false)`
`74`	`74`	`key = if pair[1] === nothing`
`75`	`75`	`"null" # this is what the YAML parser interprets as 'nothing'`
`76`	`76`	`elseif pair[1] isa AbstractString && (`
`77`		- occursin('#', pair[1]) \|\| first(pair[1]) in "{}[]&*?\|-<>=!%@:`,\"'"
	`77`	+ isempty(pair[1]) \|\| occursin('#', pair[1]) \|\| first(pair[1]) in "{}[]&*?\|-<>=!%@:`,\"'"
`78`	`78`	`)`
`79`	`79`	`string("\"", escape_string(pair[1]), "\"") # special keys that require quoting`
`80`	`80`	`else`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ const tests = [`
`50`	`50`	`"utf-32-be",`
`51`	`51`	`"empty_tag",`
`52`	`52`	`"empty_list_elem",`
	`53`	`+ "empty_key",`
`53`	`54`	`]`
`54`	`55`
`55`	`56`	`# ignore some test cases in write_and_load testing`