refactor(jans-cedarling): inline health status

Signed-off-by: dagregi <dagmawi.m@proton.me>

Author: dagregi

jans-cedarling/cedarling/src/lock/health_ticker.rs

@@ -17,6 +17,7 @@ use super::transport::{AuditItem, AuditKind, AuditPayload, AuditTransport};
 use crate::app_types::{ApplicationName, PdpID};
 use crate::http::{JoinHandle, spawn_task};
 use crate::lock::LockLogEntry;
+use crate::lock::health_registry::{HealthStatus, SystemHealth};
 use crate::log::{LogWriter, LoggerWeak};
 
 pub(super) struct HealthTickerParams {
@@ -100,7 +101,13 @@ impl<T: AuditTransport + 'static> HealthTicker<T> {
         let now = Utc::now().to_rfc3339();
         let engine_status = self.registry.collect();
 
-        let overall_status = self.registry.compute_status();
+        let overall_status = if engine_status.is_empty() {
+            SystemHealth::Unknown
+        } else if engine_status.values().all(|s| *s == HealthStatus::Success) {
+            SystemHealth::Running
+        } else {
+            SystemHealth::Degraded
+        };
 
         LockServerHealthEntry {
             creation_date: now.clone(),

jans-cedarling/cedarling/src/lock/transport/mapping.rs

@@ -8,7 +8,7 @@ use std::collections::HashMap;
 use serde::{Deserialize, Serialize};
 use serde_json::Value;
 
-use crate::lock::health_registry::HealthStatus;
+use crate::lock::health_registry::{HealthStatus, SystemHealth};
 use crate::lock::transport::{AuditItem, AuditPayload, TransportError};
 use crate::log::DecisionLogEntry;
 
@@ -173,7 +173,8 @@ impl TryFrom<&AuditItem> for LockServerMetricsEntry {
             node_name: item.pdp_id.to_string(),
             status: item
                 .status
-                .map_or_else(|| "unknown".to_string(), |s| s.to_string()),
+                .map_or("unknown", SystemHealth::as_str)
+                .to_string(),
             interval_secs: entry.interval_secs,
             policy_stats: entry.policy_stats.clone(),
             error_counters: entry.error_counters.clone(),