Add reentrancy regression coverage for every token callback boundary

[Jagadeeshftw]

Area: Security / reentrancy · Estimated effort: 8–12 h

Problem

The escrow tree has a reentrancy guard module and dedicated tests, but all token transfer/callback boundaries need a maintained entrypoint inventory.

Design decision required

Decide whether the guard is global, per operation, or capability-scoped and document callback assumptions.

Requirements

• Create malicious token mocks
• attempt reentry during deposit, payout, refund, and admin operations
• assert state remains unchanged on rejection.

Acceptance criteria

• Every external token boundary is covered, the guard emits/returns a deterministic failure, and successful non-reentrant paths retain behavior.

Out of scope

• Unrelated refactors, dependency upgrades, or behavior changes outside the stated scope.
• Closing, deleting, or weakening existing tests to make the change pass.

Verification

cargo test --manifest-path contracts/bounty_escrow/Cargo.toml -p escrow reentrancy -- --nocapture

PR requirements

• Explain the before/after behavior and include the evidence requested above.
• Add regression tests for the changed behavior and report relevant build, test, lint, and artifact results.
• Keep the PR focused and reference this issue.
• Please open the PR within 48 hours of assignment so the work remains active; ask a question in the issue if the scope needs clarification.

Good luck, and please join the contributor Telegram group if you want to discuss the work: https://t.me/+u5qmu35nZ7I0OTU1

[To0yeni]

@To0yeni has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I am an experienced software engineer and I can deliver on time.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @To0yeni to this issue.

[Rafiat30]

@Rafiat30 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Can i work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Rafiat30 to this issue.

[DevScoopee]

@DevScoopee has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi i fully understood what needs to be done and can deliver. Kindly assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @DevScoopee to this issue.

[Jagadeeshftw]

@Rafiat30 — Good luck with this assignment! You are now assigned to Add reentrancy regression coverage for every token callback boundary (#1740). Your immediate focus is add reentrancy regression coverage for every token callback boundary. Please read the complete issue description before starting, address every requirement and acceptance criterion in your PR, and raise a high-quality, focused implementation with the relevant tests and verification evidence. Please keep the PR focused and easy to review. Please open the PR within 48 hours of this assignment; if no PR is opened within that period, the issue may be unassigned so the work can be reassigned. You are also welcome to join our contributor Telegram group: https://t.me/+u5qmu35nZ7I0OTU1

[drips-wave]

Congratulations, @Rafiat30! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Rafiat30: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊