Folder cleanup: delete redundant installers, inline first-run setup in AdForge launchers

What users see in the root went from 4 confusing files (install.bat,
install.sh, AdForge.bat, AdForge.command) down to 2 obvious ones:
AdForge.bat and AdForge.command. One file to double-click. That's it.

How it works now
- AdForge.bat (Windows) and AdForge.command (Mac/Linux) handle the
  full first-run experience inline:
    1. Sanity-check Node is installed
    2. npm install if node_modules is missing
    3. Write default .env.local (PORT=3005, ADFORGE_SYNC_PORT=3006)
       if it doesn't exist — users change ports later from the
       launcher's Settings card, no editor required
    4. Drop a Desktop shortcut on first run (only if not already there)
    5. Hand off to the sidecar / start.sh
- Second run onwards: skips every setup step that's already done,
  jumps straight to opening the launcher.

What was deleted
- install.bat — its npm install + port-prompt + desktop-shortcut
  logic now lives inside AdForge.bat
- install.sh — same, inlined into AdForge.command
- The interactive port-picker was the one feature lost. Users now
  start on the default 3005 and change it in the launcher's
  Settings card (which already supports it).

README updates
- "Manual · Windows · 3 double-clicks" → "Manual · Windows · 2
  double-clicks" (download, then click AdForge.bat once — done).
- Removed the install.bat / install.sh row from the Start/Stop
  reference table.
- "Pick your own port" section rewritten — change from launcher
  Settings, no install rerun needed.
- File tree updated.

One-line online installers (scripts/install/install.{ps1,sh}) are
unaffected — they're never user-facing in the folder anyway, just
fetched via raw GitHub URL from the iwr|iex / curl|bash one-liner.

Verified: typecheck + 43 tests + build all pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: IamRamgarhia

AdForge.bat

@@ -41,12 +41,46 @@ if errorlevel 1 (
     exit /b 1
 )
 
-REM --- Make sure node_modules + data dir exist ---
+REM --- First-run setup is inlined here (no separate install.bat anymore) ---
+
+REM 1. npm install if node_modules is missing
 if not exist node_modules (
-    echo node_modules missing. Running install.bat first...
-    call install.bat
-    if errorlevel 1 exit /b 1
+    echo.
+    echo ==================================================
+    echo  First run · installing dependencies
+    echo ==================================================
+    echo This takes 1-3 minutes. You will only see this once.
+    echo.
+    call npm install --no-audit --no-fund
+    if errorlevel 1 (
+        echo.
+        echo [ERROR] npm install failed. Read the error above and try again.
+        echo.
+        pause
+        exit /b 1
+    )
+)
+
+REM 2. Write default .env.local if it doesn't exist (user can change ports later
+REM    from the launcher's Settings card without re-running anything)
+if not exist .env.local (
+    > .env.local echo # AdForge configuration ^(default ports - change in launcher Settings if needed^)
+    >> .env.local echo PORT=3005
+    >> .env.local echo ADFORGE_SYNC_PORT=3006
 )
+
+REM 3. Create Desktop shortcut on first run (only if it isn't already there)
+powershell -NoProfile -Command ^
+  "$d = [Environment]::GetFolderPath('Desktop');" ^
+  "$lnk = Join-Path $d 'AdForge.lnk';" ^
+  "if (-not (Test-Path $lnk)) {" ^
+  "  $t = Join-Path '%CD%' 'AdForge.bat';" ^
+  "  $s = (New-Object -ComObject WScript.Shell).CreateShortcut($lnk);" ^
+  "  $s.TargetPath = $t; $s.WorkingDirectory = '%CD%';" ^
+  "  $s.Description = 'Launch AdForge'; $s.WindowStyle = 7; $s.Save();" ^
+  "  Write-Host '  -> Created Desktop shortcut: ' $lnk" ^
+  "}" 2>nul
+
 if not exist data mkdir data
 
 REM --- Spawn the sidecar detached, hidden, with the right env var ---

AdForge.command

@@ -1,16 +1,72 @@
 #!/usr/bin/env bash
 # AdForge desktop launcher (macOS / Linux).
 #
-# Double-click this file in Finder / your file manager to launch the AdForge
-# launcher control panel in your default browser. macOS opens .command files
-# in Terminal automatically; on Linux, mark it executable (it already is) and
+# Double-click this file in Finder / your file manager. macOS opens .command
+# files in Terminal automatically; on Linux, mark it executable and either
 # associate it with your terminal or just run it from the file manager.
 #
-# This is the Mac/Linux equivalent of AdForge.hta on Windows. Browsers on
-# these platforms can't spawn processes from a local HTML file (sandbox), so
-# a shell script with a clear filename serves the same purpose: one click,
-# server up, browser opens.
+# First run does setup automatically: npm install, write default .env.local,
+# create a Desktop shortcut. Subsequent runs just open the launcher.
 
 set -e
 cd "$(dirname "$0")"
+
+# 1. Sanity: Node installed?
+if ! command -v node >/dev/null 2>&1; then
+  echo
+  echo "[ERROR] Node.js is not installed."
+  echo "  Install Node 20+ from https://nodejs.org/en/download then run AdForge again."
+  echo
+  read -p "Press enter to exit…" _
+  exit 1
+fi
+
+# 2. npm install on first run
+if [ ! -d node_modules ]; then
+  echo
+  echo "=================================================="
+  echo " First run · installing dependencies"
+  echo "=================================================="
+  echo " This takes 1-3 minutes. You will only see this once."
+  echo
+  npm install --no-audit --no-fund
+fi
+
+# 3. Default .env.local (ports can be changed later in the launcher's Settings card)
+if [ ! -f .env.local ]; then
+  cat > .env.local <<EOF
+# AdForge configuration (default ports - change in launcher Settings if needed)
+PORT=3005
+ADFORGE_SYNC_PORT=3006
+EOF
+fi
+
+# 4. Desktop shortcut on first run (only if missing)
+if [ -d "$HOME/Desktop" ]; then
+  if [ "$(uname)" = "Darwin" ]; then
+    if [ ! -e "$HOME/Desktop/AdForge.command" ]; then
+      cp -f AdForge.command "$HOME/Desktop/AdForge.command" 2>/dev/null && \
+        chmod +x "$HOME/Desktop/AdForge.command" 2>/dev/null && \
+        echo "  -> Created Desktop shortcut: ~/Desktop/AdForge.command"
+    fi
+  else
+    if [ ! -e "$HOME/Desktop/AdForge.desktop" ]; then
+      cat > "$HOME/Desktop/AdForge.desktop" <<DESK
+[Desktop Entry]
+Type=Application
+Name=AdForge
+Comment=Local AI ad operations cockpit
+Exec=bash $(pwd)/AdForge.command
+Terminal=true
+Categories=Office;Development;
+DESK
+      chmod +x "$HOME/Desktop/AdForge.desktop" 2>/dev/null
+      echo "  -> Created Desktop shortcut: ~/Desktop/AdForge.desktop"
+    fi
+  fi
+fi
+
+mkdir -p data
+
+# 5. Hand off to the launcher sidecar (visible log, Ctrl+C exits)
 exec bash scripts/start.sh

README.md

@@ -72,21 +72,18 @@ curl -fsSL https://raw.githubusercontent.com/IamRamgarhia/AdForge-/main/scripts/
 
 That single command: installs Node + git if missing (Windows uses winget), clones the repo into `~/AdForge`, runs `npm install`, asks for a port, then opens the launcher control panel in your browser. Click **▶ Start AdForge** and you're live.
 
-### Manual · Windows · 3 double-clicks
+### Manual · Windows · 2 double-clicks
 1. **Download** this repo (green "Code" button → "Download ZIP" → extract)
-2. **Double-click `install.bat`** · waits for dependencies, asks for a port, creates an **AdForge** shortcut on your Desktop
-3. **Double-click the new `AdForge` icon on your Desktop** *(or `AdForge.bat` in the folder)* · your default browser opens to the AdForge launcher
+2. **Double-click `AdForge.bat`** — that's it. First run installs Node dependencies, writes a default `.env.local`, drops an `AdForge` shortcut on your Desktop, then opens the launcher. From the second run onwards it's a single click → browser opens to the launcher.
 
-The launcher is a control panel: hit **▶ Start AdForge**, watch the progress bar, then click **↗ Open AdForge** when it's up. From the launcher you can also stop, restart, change ports, and open three different local URLs.
+The launcher is a control panel: hit **▶ Start AdForge**, watch the progress bar, then click **↗ Open AdForge** when it's up. From the launcher you can stop, restart, change ports, see update notices, and open three different local URLs.
 
 To shut everything down: close the launcher tab and run `scripts\stop.bat` (or just close the hidden sidecar via Task Manager).
 
-### Manual · Mac / Linux · 3 commands
+### Manual · Mac / Linux · 2 commands
 ```bash
-git clone https://github.com/IamRamgarhia/AdForge-.git adforge
-cd adforge
-bash install.sh                  # one-time setup · creates ~/Desktop/AdForge shortcut
-bash AdForge.command             # or double-click AdForge on your Desktop
+git clone https://github.com/IamRamgarhia/AdForge.git adforge && cd adforge
+bash AdForge.command             # first run installs + creates Desktop shortcut · subsequent runs just launch
 # bash scripts/stop.sh           # to force-stop later
 ```
 
@@ -99,7 +96,7 @@ npm run start:all      # web app + local-sync sidecar together
 > First launch walks you through a 5-step wizard: welcome → tour → pick AI provider → paste key → optional first brand. No accounts. No env vars. No database.
 
 ### Pick your own port
-`install.bat` / `install.sh` ask which port you want and save it to `.env.local`. Defaults to **3005**. Pick anything 1024–65535 (avoid 80 unless you want admin rights).
+The default is **3005** for the web app and **3006** for the sidecar. Change either from the launcher's **Settings** card any time — no editor needed. Pick anything 1024–65535 (avoid 80 unless you want admin rights).
 
 ### Want a prettier URL?
 - **Zero setup:** open `http://adforge.localhost:3005/` instead of `http://localhost:3005/`. Works in Chrome / Firefox / Safari / Edge today — all modern browsers auto-resolve `*.localhost` to 127.0.0.1.
@@ -307,9 +304,8 @@ adforge/
 │
 ├── data/                        Your snapshot lives here (gitignored)
 ├── AdForge.bat / AdForge.command  Click-to-launch (Desktop shortcut points here)
-├── install.bat / install.sh       Manual installer (after you clone/unzip)
-├── scripts/install/install.ps1    One-line online bootstrap (Windows · PowerShell)
-├── scripts/install/install.sh     One-line online bootstrap (Mac / Linux / WSL)
+├── scripts/install/install.ps1    One-line online bootstrap (Windows · PowerShell · iwr | iex)
+├── scripts/install/install.sh     One-line online bootstrap (Mac / Linux / WSL · curl | bash)
 ├── scripts/start.bat / start.sh    Manual sidecar runner (advanced)
 ├── scripts/stop.bat / stop.sh      Force shutdown
 └── package.json
@@ -337,8 +333,7 @@ Production build: 56 statically prerendered routes · 87 KB shared JS · 130-160
 
 | Action | Windows | Mac / Linux | Cross-platform |
 |---|---|---|---|
-| Install (one-time) | double-click `install.bat` | `bash install.sh` | `npm install` |
-| **Launch** | double-click `AdForge` on Desktop *(or `AdForge.bat`)* | double-click `AdForge` on Desktop *(or `bash AdForge.command`)* | — |
+| Install + Launch | double-click `AdForge.bat` — first run installs, every run after just launches | `bash AdForge.command` (same: first run sets up, after that it just launches) | `npm install && npm run start:all` |
 | Force-stop everything | `scripts\stop.bat` | `bash scripts/stop.sh` | Ctrl+C in the sidecar window |
 | Manual sidecar (visible log) | `scripts\start.bat` | `bash scripts/start.sh` | `npm run start:all` |
 | Web only | `npm run dev` | `npm run dev` | `npm run dev` |