ai: update skills, chores

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

Author: acpana

.agents/greenfield-direct-new-resource-types.md

@@ -76,6 +76,7 @@ To ensure stability and reproducibility, this task is pinned to the following re
 2. **Implement Identity**: Use skill `.gemini/skills/kcc-direct-identity-implementer/SKILL.md` with:
    - resource_kind: <Kind>
    - template: <GCP_URL_Template> (e.g. projects/{project}/locations/{location}/<plural>/{<resource>})
+   - **Crucial**: Ensure you also create the corresponding `_identity_test.go` file.
 
 3. **Run local validations**:
    - run `scripts/validate-prereqs.sh`, if the script fails the output will contain agent hints for fixing the errors.

.gemini/skills/kcc-direct-greenfield-types-implementer/SKILL.md

@@ -41,6 +41,24 @@ Apply the baseline validations from `kcc-direct-base-types-implementer`, plus th
 - **Enums**: 
   - Use `*string` for the Go type of proto enum fields (do NOT use custom wrapped string types).
   - Use `// +kubebuilder:validation:Enum=VALUE1;VALUE2` to provide validation in the CRD while keeping the Go type simple.
+- **Naming Conventions & Acronyms**:
+  - Structs in `*_types.go` must be strictly CamelCased (no snake_case allowed).
+  - Ensure GCP acronyms are capitalized correctly in resource and field names (e.g., `APIHub`, `SIP`, `JSON`, `PDF`, `DER`, `CEL`).
+  - **No Exceptions**: Do **NOT** add new exceptions to `tests/apichecks/testdata/exceptions/acronyms.txt`. Fix the Go field names instead.
+- **Pointers**: Validate that optional or nullable fields (like `Location`, booleans, integers) are correctly typed as pointers (e.g., `*string`, `*bool`) rather than raw values.
+- **ETag Exclusion**: Remove `etag` fields from the KRM spec; they are generally disallowed. Do **NOT** add exceptions to `spec_dislike_etag.txt`.
+- **KCC References (`missingrefs.txt`)**:
+  - Ensure fields representing GCP resources are implemented using the KCC Ref pattern (e.g., `ProjectRef`, `NetworkRef`) rather than plain strings.
+  - **No Exceptions**: Do **NOT** add exceptions to `tests/apichecks/testdata/exceptions/missingrefs.txt`. Fix the underlying field types instead.
+  - Reuse existing refs from `apis/refs/v1beta1/` (e.g., `Compute`, `BigQueryDataset`). If creating a new ref, put it in a service-specific file (e.g., `apis/dlp/v1alpha1/dlprefs.go`).
+- **Avoiding Scope Creep**:
+  - Do **NOT** modify anything under `apis/<service>/v1beta1/` (especially `generate.sh` scripts) when implementing a `v1alpha1` resource.
+  - Do **NOT** add CI presubmits/workflows (e.g., `.github/workflows/ci-presubmit.yaml`).
+  - Do **NOT** include the controller implementation (`pkg/controller/direct/...`).
+- **Package Collisions & Generation**:
+  - Instead of copying raw protos into `mockgcp/`, use the `generate.sh` script with the specific upstream SHA to fetch the protos.
+  - Ensure `docs/reports/crd_report.md` and `.csv` are correctly updated and committed after running `make generate`.
+  - If validations fail, ensure Go clients are regenerated (`./scripts/generate-go-crd-clients/generate-clients.sh`).
 
 ### 4. Journaling
 Append any quirks about the proto-to-struct mapping (e.g., field name collisions) to `.gemini/journals/<service>.md` using the format described in the `kcc-agentic-journaler` skill.

.gemini/skills/kcc-direct-identity-implementer/SKILL.md

@@ -21,7 +21,12 @@ This skill guides the implementation of the IdentityV2 and ExternalIdentifier in
     - Implement `ExternalIdentifier()`.
     - Implement `ParentString() string` to return the GCP parent URI (e.g., `projects/{project}` or `projects/{project}/locations/{location}`).
 
-2.  **Parent & Hierarchy Support**:
+2.  **Implement Identity Tests**:
+    Create `apis/<service>/<api_version>/<resource_lower>_identity_test.go`.
+    - Ensure every `<resource_lower>_identity.go` file has a corresponding test file.
+    - The test file should verify that `FromExternal()` can parse valid external identities and `String()` can generate correct external identities.
+
+3.  **Parent & Hierarchy Support**:
     - Ensure the `Spec` struct has a `ProjectRef` (and `Location` if applicable).
     - **Hierarchical Branching**: If the GCP resource supports multiple hierarchies (e.g., Global and Regional), implement logic in `String()` and `FromExternal()` to handle both. Use the presence of the `location` field in the Spec to determine which pattern to use.