Skip to content
This repository was archived by the owner on Jan 8, 2026. It is now read-only.

Commit f935ee2

Browse files
committed
Fix StreamOps.{read,readAsync,write} type definitions.
1 parent bf82248 commit f935ee2

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/app.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -382,12 +382,12 @@ declare global {
382382
return readBytes.length;
383383
},
384384

385-
write: (_stream, buffer, offset, length) => {
385+
write: (_stream, signedBuffer, offset, length) => {
386386
// Note: default `buffer` is for some reason `HEAP8` (signed), while we want unsigned `HEAPU8`.
387-
buffer = new Uint8Array(
388-
buffer.buffer,
389-
buffer.byteOffset,
390-
buffer.byteLength,
387+
let buffer = new Uint8Array(
388+
signedBuffer.buffer,
389+
signedBuffer.byteOffset,
390+
signedBuffer.byteLength,
391391
);
392392
xterm.write(buffer.subarray(offset, offset + length));
393393
return length;

src/vendor/pyodide.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ declare namespace FS {
6363
interface StreamOps {
6464
open?: (stream: FSStream) => void;
6565
close?: (stream: FSStream) => void;
66-
read?: (stream: FSStream, buffer: Uint8Array, offset: number, length: number, position: number) => number;
67-
readAsync?: (stream: FSStream, buffer: Uint8Array, offset: number, length: number, position: number) => Promise<number>;
68-
write?: (stream: FSStream, buffer: Uint8Array, offset: number, length: number, position: number) => number;
66+
read?: (stream: FSStream, buffer: Int8Array, offset: number, length: number, position: number) => number;
67+
readAsync?: (stream: FSStream, buffer: Int8Array, offset: number, length: number, position: number) => Promise<number>;
68+
write?: (stream: FSStream, buffer: Int8Array, offset: number, length: number, position: number) => number;
6969
llseek?: (stream: FSStream, offset: number, whence: number) => number;
7070
pollAsync?: (stream: FSStream, timeout: number) => Promise<number>;
7171
ioctl?: (stream: FSStream, request: number, varargs: number) => number;

0 commit comments

Comments
 (0)