Remove ancient events which have been deprecated and marked for removal for a while now, pin events / base api to timestamped builds

Author: onebeastchris

BREAKING_CHANGES.md

@@ -1,6 +1,8 @@
 # Overview of breaking changes for THE MERGE
 
 API
+- Removed ServerDefineCommandsEvent, which has been deprecated & marked for removal since 2023
+- Removed GeyserLoadResourcePacksEvent
 
 Functionality
 - geyser root commands now always have a permission attached to them, which is granted by default

api/src/main/java/org/geysermc/geyser/api/event/bedrock/ClientEmoteEvent.java

@@ -100,16 +100,4 @@ public boolean cancelled() {
     public void cancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
-
-    @Override
-    @Deprecated
-    public boolean isCancelled() {
-        return cancelled();
-    }
-
-    @Override
-    @Deprecated
-    public void setCancelled(boolean cancelled) {
-        cancelled(cancelled);
-    }
 }

api/src/main/java/org/geysermc/geyser/api/event/bedrock/SessionLoginEvent.java

@@ -89,18 +89,6 @@ public void cancelled(boolean cancelled, String disconnectReason) {
         this.disconnectReason = disconnectReason;
     }
 
-    @Override
-    @Deprecated
-    public boolean isCancelled() {
-        return cancelled();
-    }
-
-    @Override
-    @Deprecated
-    public void setCancelled(boolean cancelled) {
-        cancelled(cancelled);
-    }
-
     @Deprecated
     public void setCancelled(boolean cancelled, String disconnectReason) {
         cancelled(cancelled, disconnectReason);

api/src/main/java/org/geysermc/geyser/api/event/connection/ConnectionRequestEvent.java

@@ -104,28 +104,4 @@ public boolean cancelled() {
     public void cancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
-
-    /**
-     * The cancel status of this event. If this event is cancelled, the connection will be rejected.
-     *
-     * @return the cancel status of this event
-     * @deprecated use {@link #cancelled()} instead
-     */
-    @Override
-    @Deprecated(forRemoval = true)
-    public boolean isCancelled() {
-        return cancelled;
-    }
-
-    /**
-     * Sets the cancel status of this event. If this event is canceled, the connection will be rejected.
-     *
-     * @param cancelled the cancel status of this event.
-     * @deprecated use {@link #cancelled(boolean)} instead
-     */
-    @Override
-    @Deprecated(forRemoval = true)
-    public void setCancelled(boolean cancelled) {
-        this.cancelled = cancelled;
-    }
 }

api/src/main/java/org/geysermc/geyser/api/event/downstream/ServerDefineCommandsEvent.java

@@ -65,18 +65,6 @@ public void cancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
 
-    @Override
-    @Deprecated
-    public boolean isCancelled() {
-        return cancelled();
-    }
-
-    @Override
-    @Deprecated
-    public void setCancelled(boolean cancelled) {
-        cancelled(cancelled);
-    }
-
     public interface CommandInfo {
         /**
          * Gets the name of the command.

api/src/main/java/org/geysermc/geyser/api/event/downstream/package-info.java

@@ -116,16 +116,6 @@ public boolean callServerSpawnEvent() {
         ServerSpawnEntityEvent event = new ServerSpawnEntityEvent(session) {
             private boolean cancelled = false;
 
-            @Override
-            public boolean isCancelled() {
-                return cancelled();
-            }
-
-            @Override
-            public void setCancelled(boolean cancelled) {
-                cancelled(cancelled);
-            }
-
             @Override
             public boolean cancelled() {
                 return cancelled || bedrockEntityDefinition == null;
@@ -245,16 +235,6 @@ public void cancelled(boolean cancelled) {
                 this.cancelled = cancelled;
             }
 
-            @Override
-            public boolean isCancelled() {
-                return cancelled();
-            }
-
-            @Override
-            public void setCancelled(boolean cancelled) {
-                cancelled(cancelled);
-            }
-
             @Override
             public void preSpawnConsumer(@NonNull Consumer<@NonNull GeyserEntity> consumer) {
                 Objects.requireNonNull(consumer, "consumer cannot be null!");

api/src/main/java/org/geysermc/geyser/api/event/java/ServerDefineCommandsEvent.java

@@ -30,7 +30,6 @@
 import it.unimi.dsi.fastutil.objects.Object2ObjectOpenHashMap;
 import org.checkerframework.checker.nullness.qual.NonNull;
 import org.geysermc.geyser.GeyserImpl;
-import org.geysermc.geyser.api.event.lifecycle.GeyserLoadResourcePacksEvent;
 import org.geysermc.geyser.api.pack.PathPackCodec;
 import org.geysermc.geyser.api.pack.ResourcePack;
 import org.geysermc.geyser.api.pack.ResourcePackManifest;
@@ -120,13 +119,8 @@ public Map<UUID, ResourcePackHolder> load(Path directory) {
             resourcePacks.add(skullResourcePack);
         }
 
-        //noinspection deprecation - we know
-        GeyserLoadResourcePacksEvent event = new GeyserLoadResourcePacksEvent(resourcePacks);
-        GeyserImpl.getInstance().eventBus().fire(event);
-
         GeyserDefineResourcePacksEventImpl defineEvent = new GeyserDefineResourcePacksEventImpl(packMap);
-
-        for (Path path : event.resourcePacks()) {
+        for (Path path : resourcePacks) {
             try {
                 defineEvent.register(readPack(path).build());
             } catch (Exception e) {