test: correct case assumption

Author: mogita

models.go

@@ -26,17 +26,38 @@ func (c *StubHTTPClient) Do(req *http.Request) (*http.Response, error) {
 
 func WaitForTask(ctx context.Context, client *Stream, taskID string) (*StreamResponse[GetTaskResponse], error) {
 	// Poll with progressive intervals: start at 1s, increase by 1s each
-	// attempt up to 5s, for a total ceiling of ~120s. This handles slow
+	// attempt up to 5s, for a total ceiling of ~190s. This handles slow
 	// task completion under heavy parallel load while still finishing
 	// quickly when the server is responsive.
+	//
+	// "failed" is treated as non-terminal until it persists for at least
+	// failedConfirmDuration. The chat backend writes Status="failed" before
+	// asynq retries rate-limited or transient-internal failures; retries are
+	// scheduled 10-15s out (rateLimitAwareRetryDelay), and the next attempt
+	// overwrites the result with "running" then "completed". Any non-failed
+	// observation resets the deadline so chains of retries don't time out.
 	const maxAttempts = 40
+	const failedConfirmDuration = 30 * time.Second
+	var lastResult *StreamResponse[GetTaskResponse]
+	var firstFailedAt time.Time
 	for i := 0; i < maxAttempts; i++ {
 		taskResult, err := client.GetTask(context.Background(), taskID, &GetTaskRequest{})
 		if err != nil {
 			return nil, fmt.Errorf("failed to get task result: %w", err)
 		}
-		if taskResult.Data.Status == "completed" || taskResult.Data.Status == "failed" {
+		lastResult = taskResult
+		switch taskResult.Data.Status {
+		case "completed":
 			return taskResult, nil
+		case "failed":
+			if firstFailedAt.IsZero() {
+				firstFailedAt = time.Now()
+			}
+			if time.Since(firstFailedAt) >= failedConfirmDuration {
+				return taskResult, nil
+			}
+		default:
+			firstFailedAt = time.Time{}
 		}
 
 		interval := time.Duration(i+1) * time.Second
@@ -50,6 +71,9 @@ func WaitForTask(ctx context.Context, client *Stream, taskID string) (*StreamRes
 		case <-time.After(interval):
 		}
 	}
+	if lastResult != nil {
+		return lastResult, fmt.Errorf("task %s did not complete after %d attempts (last status %q)", taskID, maxAttempts, lastResult.Data.Status)
+	}
 	return nil, fmt.Errorf("task %s did not complete after %d attempts", taskID, maxAttempts)
 }