Skip to content

Weird divisor when projecting octahedron probe texture to spherical harmonics. #21

Description

@Hineven

float3 radiance = g_ScreenProbes_ProbeBuffer[probe_pos].xyz / g_ScreenProbesConstants.probe_size;

The line of code above weights the number of hemispherical samples by 1/probe_size when computing SH coefficients for later shading, however the number of samples is probe_size*probe_size. The normalization seems incorrect however if i change the weight to 1/(probe_size*probe_size) the scene seems to be too dark compared to the ray-traced reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions