Clarification about sorting in MusicBrainz stage

[pedorich-n]

In the docs the sensible default for releaseGroupPrimaryTypePriority is defined as ["album", "single", "ep"], which in my mind means albums get the highest priority, then singles and EPs are last. But I kept getting singles assigned. I checked the code:

multi-scrobbler/src/backend/common/transforms/MusicbrainzTransformer.ts

Line 925 in d9184fa

const grpPAScore = releaseGroupPrimaryTypePriority.findIndex(x => x === a["release-group"]?.["primary-type"]?.toLocaleLowerCase()) + 1;

and if I'm reading it correctly, the index in the list is used as a score, meaning the later the item in the list, the higher the score.

From my tests, reversing the list to ["ep", "single", "album"] caused Albums to appear instead of Singles.

Is my understanding correct?

If yes, could we clarify it in the docs? IMO it's confusing that for "searchOrder": ["isrc", "basic", "artist"] isrc (first item) has the highest priority, but for *Pritority fields, the latest is highest.

[FoxxMD]

That is definitely a bug, thanks for catching that! I've pushed a fixed that corrects the order of release ranking so its consistent and what you expect (first item has highest priority). You can use this fix in the edge docker image, or this specific digest:

ghcr.io/foxxmd/multi-scrobbler:edge@sha256:7b3942abb64914447eed76c952d017c2dcdd19d178d27c354896155222acea54

[pedorich-n]

Thanks!