Skip to content

Commit b681cb8

Browse files
authored
fix "false" mv value (#246)
1 parent fa26991 commit b681cb8

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

frontend/common/utils/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module.exports = Object.assign({}, require('./base/_utils'), {
2828
return null;
2929
}
3030

31-
return Utils.getTypedValue(featureState.boolean_value || featureState.integer_value || featureState.string_value);
31+
return Utils.getTypedValue(featureState.integer_value || featureState.string_value || featureState.boolean_value);
3232
},
3333
valueToFeatureState(value) {
3434
const val = Utils.getTypedValue(value);

frontend/web/components/modals/CreateFlag.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ const CreateFlag = class extends Component {
408408
<ValueEditor
409409
data-test="featureValue"
410410
name="featureValue" className="full-width"
411-
value={initial_value}
411+
value={initial_value + ""}
412412
onChange={e => this.setState({ initial_value: Utils.getTypedValue(Utils.safeParseEventValue(e)) })}
413413
disabled={hide_from_client}
414414
placeholder="e.g. 'big' "

frontend/web/components/mv/VariationValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const VariationValue = ({
1717
<ValueEditor
1818
data-test="featureValue"
1919
name="featureValue" className="full-width"
20-
value={Utils.getTypedValue(Utils.featureStateToValue(value))}
20+
value={Utils.getTypedValue(Utils.featureStateToValue(value)) + ""}
2121
onChange={(e) => {
2222
onChange({
2323
...value,

0 commit comments

Comments
 (0)