tests: topotests: EVPN VXLAN MH extern learn mode tests

Topotests added under bgp_evpn_mh_l2l3vni_ext_learn to:
- Validate correct ES discovery and advertisement for both local and
  remote PEs.
- Check VTEP peer lists for accuracy, including handling of downed VTEPs
  and ES state transitions.
- Ensure L2VNI and L3VNI are correctly instantiated and associated with the
  appropriate VRFs and VXLAN interfaces.
- Test orphaned hosts, dual-attached hosts, and single-attached hosts
  in various failure and recovery scenarios.
- MAC 'protocol' state transitions i.e data plane learnt to
  control plane learnt and vice versa, delete, relearn in both peers
  sequences

Utility and Parser Functions:
Utility functions in lib/bgp_evpn.py(new) are added.
These changes add the test coverage and reliability for EVPN VXLAN
multihoming in external mode, making it easier to detect regressions and
validate new features.

Signed-off-by: Patrice Brissette <pbrisset@cisco.com>
Signed-off-by: Tamer Ahmed <tamerahmed@microsoft.com>

Author: pbrisset

tests/topotests/bgp_evpn_mh/test_evpn_mh.py

@@ -37,6 +37,9 @@
 # Required to instantiate the topology builder class.
 from lib.topogen import Topogen, TopoRouter, get_topogen
 
+# bgp_evpn library
+from lib import bgp_evpn
+
 #####################################################
 ##
 ##   Network Topology Definition
@@ -210,36 +213,6 @@ def build_topo(tgen):
 }
 
 
-def config_bond(node, bond_name, bond_members, bond_ad_sys_mac, br):
-    """
-    Used to setup bonds on the TORs and hosts for MH
-    """
-    node.run("ip link add dev %s type bond mode 802.3ad" % bond_name)
-    node.run("ip link set dev %s type bond lacp_rate 1" % bond_name)
-    node.run("ip link set dev %s type bond miimon 100" % bond_name)
-    node.run("ip link set dev %s type bond xmit_hash_policy layer3+4" % bond_name)
-    node.run("ip link set dev %s type bond min_links 1" % bond_name)
-    node.run(
-        "ip link set dev %s type bond ad_actor_system %s" % (bond_name, bond_ad_sys_mac)
-    )
-
-    for bond_member in bond_members:
-        node.run("ip link set dev %s down" % bond_member)
-        node.run("ip link set dev %s master %s" % (bond_member, bond_name))
-        node.run("ip link set dev %s up" % bond_member)
-
-    node.run("ip link set dev %s up" % bond_name)
-
-    # if bridge is specified add the bond as a bridge member
-    if br:
-        node.run(" ip link set dev %s master bridge" % bond_name)
-        node.run("/sbin/bridge link set dev %s priority 8" % bond_name)
-        node.run("/sbin/bridge vlan del vid 1 dev %s" % bond_name)
-        node.run("/sbin/bridge vlan del vid 1 untagged pvid dev %s" % bond_name)
-        node.run("/sbin/bridge vlan add vid 1000 dev %s" % bond_name)
-        node.run("/sbin/bridge vlan add vid 1000 untagged pvid dev %s" % bond_name)
-
-
 def attach_bond_to_bridge(node, bond_name):
     """
     Re-attach an existing bond to the bridge with VLAN settings.
@@ -338,10 +311,10 @@ def config_tor(tor_name, tor, tor_ip, svi_pip):
     else:
         sys_mac = "44:38:39:ff:ff:02"
     bond_member = tor_name + "-eth2"
-    config_bond(tor, "hostbond1", [bond_member], sys_mac, "bridge")
+    bgp_evpn.config_bond(tor, "hostbond1", [bond_member], sys_mac, "bridge")
 
     bond_member = tor_name + "-eth3"
-    config_bond(tor, "hostbond2", [bond_member], sys_mac, "bridge")
+    bgp_evpn.config_bond(tor, "hostbond2", [bond_member], sys_mac, "bridge")
 
     # create SVI
     config_svi(tor, svi_pip)
@@ -361,25 +334,11 @@ def compute_host_ip_mac(host_name):
     return host_ip, host_mac
 
 
-def config_host(host_name, host):
-    """
-    Create the dual-attached bond on host nodes for MH
-    """
-    bond_members = []
-    bond_members.append(host_name + "-eth0")
-    bond_members.append(host_name + "-eth1")
-    bond_name = "torbond"
-    config_bond(host, bond_name, bond_members, "00:00:00:00:00:00", None)
-
-    host_ip, host_mac = compute_host_ip_mac(host_name)
-    host.run("ip addr add %s dev %s" % (host_ip, bond_name))
-    host.run("ip link set dev %s address %s" % (bond_name, host_mac))
-
-
 def config_hosts(tgen, hosts):
     for host_name in hosts:
         host = tgen.gears[host_name]
-        config_host(host_name, host)
+        host_ip, host_mac = compute_host_ip_mac(host_name)
+        bgp_evpn.config_host(host_name, host, host_ip, host_mac)
 
 
 def setup_module(module):

tests/topotests/bgp_evpn_mh_l2l3vni_ext_learn/spine1/frr.conf

@@ -0,0 +1,34 @@
+int spine1-eth0
+  ip addr 192.168.1.1/24
+!
+int spine1-eth1
+  ip addr 192.168.2.1/24
+!
+int spine1-eth2
+  ip addr 192.168.3.1/24
+!
+int spine1-eth3
+  ip addr 192.168.4.1/24
+!
+int lo
+  ip addr 192.168.100.13/32
+  ip addr 192.168.100.100/32
+!
+frr defaults datacenter
+!
+router bgp 65001
+  bgp router-id 192.168.100.13
+  no bgp ebgp-requires-policy
+
+  neighbor TRANSIT_OVERLAY peer-group
+  neighbor TRANSIT_OVERLAY remote-as external
+
+  neighbor 192.168.1.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.2.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.3.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.4.2 peer-group TRANSIT_OVERLAY
+  redistribute connected
+  address-family l2vpn evpn
+    neighbor TRANSIT_OVERLAY activate
+  exit-address-family
+!

tests/topotests/bgp_evpn_mh_l2l3vni_ext_learn/spine2/frr.conf

@@ -0,0 +1,34 @@
+int spine2-eth0
+  ip addr 192.168.5.1/24
+!
+int spine2-eth1
+  ip addr 192.168.6.1/24
+!
+int spine2-eth2
+  ip addr 192.168.7.1/24
+!
+int spine2-eth3
+  ip addr 192.168.8.1/24
+!
+int lo
+  ip addr 192.168.100.14/32
+  ip addr 192.168.100.100/32
+!
+frr defaults datacenter
+!
+router bgp 65002
+  bgp router-id 192.168.100.14
+  no bgp ebgp-requires-policy
+
+  neighbor TRANSIT_OVERLAY peer-group
+  neighbor TRANSIT_OVERLAY remote-as external
+
+  neighbor 192.168.5.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.6.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.7.2 peer-group TRANSIT_OVERLAY
+  neighbor 192.168.8.2 peer-group TRANSIT_OVERLAY
+  redistribute connected
+  address-family l2vpn evpn
+    neighbor TRANSIT_OVERLAY activate
+  exit-address-family
+!