Skip to content

Commit 1084355

Browse files
committed
fixes after merge
1 parent 085d6d7 commit 1084355

7 files changed

Lines changed: 11 additions & 10 deletions

File tree

.github/workflows/nf-test-e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- name: Checkout
1515
uses: actions/checkout@v4
1616

17-
- name: Setup Nextflow
17+
- name: Setup Nextflow
1818
uses: nf-core/setup-nextflow@v1
1919
with:
2020
version: "25.10.0"

.github/workflows/nf-test-subwf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- name: Checkout
1515
uses: actions/checkout@v4
1616

17-
- name: Setup Nextflow
17+
- name: Setup Nextflow
1818
uses: nf-core/setup-nextflow@v1
1919
with:
2020
version: "25.10.0"

bin/check_proteins_compatibility.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,8 @@ def check_compatibility(fasta: str, proteins_faa: str, proteins_gff: str) -> str
160160
return NOT_MATCHED
161161

162162
contigs_included = all(
163-
any(contig_id in header for header in contig_ids) for contig_id in gff_contig_ids
163+
any(contig_id in header for header in contig_ids)
164+
for contig_id in gff_contig_ids
164165
)
165166
gff_ids_included = all(
166167
any(protein_id in header for header in faa_headers) for protein_id in gff_ids

nextflow_schema.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,11 +322,11 @@
322322
"default": "01-predictions",
323323
"description": "output directory for detected viruses step"
324324
},
325-
"prodigaldir": {
325+
"proteindir": {
326326
"type": "string",
327327
"format": "directory-path",
328-
"default": "02-prodigal",
329-
"description": "output directory for prodigal step"
328+
"default": "02-protein-prediction",
329+
"description": "output directory for protein prediction step"
330330
},
331331
"hmmerdir": {
332332
"type": "string",

subworkflows/local/proteins_compatibility/main.nf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ workflow PROTEINS_COMPATIBILITY {
1818
def resultsList = results instanceof List ? results : [results]
1919
tuple(meta, resultsList[0].name)
2020
}
21-
// Check whether a user-supplied fasta/faa/gff triplet is
21+
// Check whether a user-supplied fasta/faa/gff triplet is
2222
// internally consistent (marked matched or not_matched)
2323
// and whether the faa/gff still use prodigal's short-format protein IDs and therefore need renaming (marked require_rename)
2424
checked_records = records_with_proteins
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
id,assembly,proteins_gff,proteins_faa
2-
MGYG000495417,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/fix/remove-use-proteins/tests/test_data/MGYG000495417.fna,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/fix/remove-use-proteins/tests/test_data/MGYG000495417.gff,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/fix/remove-use-proteins/tests/test_data/MGYG000495417.faa
2+
MGYG000495417,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/4.0.0/tests/test_data/MGYG000495417.fna,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/4.0.0/tests/test_data/MGYG000495417.gff,https://raw.githubusercontent.com/EBI-Metagenomics/emg-viral-pipeline/refs/heads/4.0.0/tests/test_data/MGYG000495417.faa

workflows/virify.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ workflow VIRIFY {
160160
}
161161

162162
SPLIT_PROTEINS(category_fasta.groupTuple().join(protein_files_ch).transpose())
163-
163+
164164
proteins_ch = SPLIT_PROTEINS.out.fasta_proteins_gff
165165

166166
// ----------- ANNOTATE
@@ -197,4 +197,4 @@ workflow VIRIFY {
197197
false,
198198
false,
199199
)
200-
}
200+
}

0 commit comments

Comments
 (0)