Fix Dolibarr#36480 timesheet date comparison accepts string and timestamp

addTimeSpent, updateTimeSpent and delTimeSpent compared $this->timespent_date
(which can be a 'YYYY-MM-DD' string when called from some callers) directly
with the integer timestamp returned by dol_time_plus_duree, so the
PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS restriction silently allowed past
entries it should refuse. Normalize the left-hand side with a numeric/strtotime
guard at the three comparison sites.

Signed-off-by: Dolicraft <contact@dolicraft.com>

Author: Dolicraft

htdocs/projet/class/task.class.php

@@ -1315,7 +1315,7 @@ public function addTimeSpent($user, $notrigger = 0)
 			require_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';
 			$restrictBefore = dol_time_plus_duree(dol_now(), - $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS, 'm');
 
-			if ($this->timespent_date < $restrictBefore) {
+			if ((is_numeric($this->timespent_date) ? (int) $this->timespent_date : (int) strtotime((string) $this->timespent_date)) < $restrictBefore) {
 				$this->error = $langs->trans('TimeRecordingRestrictedToNMonthsBack', $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS);
 				$this->errors[] = $this->error;
 				return -1;
@@ -1763,7 +1763,7 @@ public function updateTimeSpent($user, $notrigger = 0)
 			require_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';
 			$restrictBefore = dol_time_plus_duree(dol_now(), - $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS, 'm');
 
-			if ($this->timespent_date < $restrictBefore) {
+			if ((is_numeric($this->timespent_date) ? (int) $this->timespent_date : (int) strtotime((string) $this->timespent_date)) < $restrictBefore) {
 				$this->error = $langs->trans('TimeRecordingRestrictedToNMonthsBack', $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS);
 				$this->errors[] = $this->error;
 				return -1;
@@ -1864,7 +1864,7 @@ public function delTimeSpent($user, $notrigger = 0)
 			require_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';
 			$restrictBefore = dol_time_plus_duree(dol_now(), - $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS, 'm');
 
-			if ($this->timespent_date < $restrictBefore) {
+			if ((is_numeric($this->timespent_date) ? (int) $this->timespent_date : (int) strtotime((string) $this->timespent_date)) < $restrictBefore) {
 				$this->error = $langs->trans('TimeRecordingRestrictedToNMonthsBack', $conf->global->PROJECT_TIMESHEET_PREVENT_AFTER_MONTHS);
 				$this->errors[] = $this->error;
 				return -1;