fix Dolibarr#33642 set user name from company for corporation member

User::create_from_member copied lastname/firstname from the member, but a
corporation member (morphy 'mor') has neither: its name is in the company
field. The created user got a blank name and an empty built login. Use the
company field as the lastname in that case so the user name and login are
populated.

Signed-off-by: Dolicraft <contact@dolicraft.com>

Author: Dolicraft

htdocs/user/class/user.class.php

@@ -1734,8 +1734,15 @@ public function create_from_member($member, $login = '')
 		// Set properties on new user
 		$this->admin = 0;
 		$this->civility_code = $member->civility_id;
-		$this->lastname     = $member->lastname;
-		$this->firstname    = $member->firstname;
+		// A corporation member has no lastname/firstname (the name is in the company field), so use it as the
+		// user lastname, otherwise the created user would have an empty name (#33642).
+		if ($member->morphy == 'mor' && empty($member->lastname) && !empty($member->company)) {
+			$this->lastname = $member->company;
+			$this->firstname = '';
+		} else {
+			$this->lastname     = $member->lastname;
+			$this->firstname    = $member->firstname;
+		}
 		$this->gender		= $member->gender;
 		$this->email        = $member->email;
 		$this->fk_member    = $member->id;
@@ -1752,7 +1759,8 @@ public function create_from_member($member, $login = '')
 
 		if (empty($login)) {
 			include_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
-			$login = dol_buildlogin($member->lastname, $member->firstname);
+			// Use the resolved name so a corporation member (name in company field) still gets a login.
+			$login = dol_buildlogin($this->lastname, $this->firstname);
 		}
 		$this->login = $login;