Narrow Unsupported attribute dismissal to missing-attribute Detail and add Unknown variable test coverage.

Author: whitemerch

pkg/parser/terraform/data_source.go

@@ -245,16 +245,10 @@ func parseDataSourceBody(ctx context.Context, body *hclsyntax.Body, inputVariabl
 		Functions: functions.TerraformFuncs,
 	})
 
-	// Dismiss diagnostics caused by unresolvable variable references so that
-	// statically-known fields in the same block are still analysed.
-	// "Unknown variable"   – var/local/module absent from the eval context entirely.
-	// "Unsupported attribute" (narrowed to the "does not have an attribute named"
-	//   detail) – var IS in the context as a cty.Object of known defaults, but
-	//   the specific variable has no default and is therefore not an attribute on
-	//   that object. We narrow by Detail to avoid silently swallowing unrelated
-	//   attribute errors (e.g. accessing a non-existent field on a resource).
-	// Both cases leave the affected field as cty.DynamicVal, handled below by
-	// cty.UnknownAsNull.
+	// Dismiss unresolvable variable references; both leave the field as
+	// cty.DynamicVal which cty.UnknownAsNull handles below.
+	// "Unsupported attribute" is narrowed by Detail to avoid swallowing
+	// unrelated attribute errors on non-variable objects.
 	for _, decErr := range decodeErrs {
 		isUnknownVar := decErr.Summary == "Unknown variable"
 		isUnsupportedAttrOnVar := decErr.Summary == "Unsupported attribute" &&

pkg/parser/terraform/data_source_test.go

@@ -20,10 +20,7 @@ func Test_getDataSourcePolicy(t *testing.T) {
 	type args struct {
 		currentPath  string
 		resourceName string
-		// inputVars seeds the variable map passed to getDataSourcePolicy.
-		// nil means an empty map (no var/local context), which is fine for
-		// fixtures that contain no variable references.
-		inputVars converter.VariableMap
+		inputVars converter.VariableMap // nil means empty map
 	}
 	tests := []struct {
 		name string
@@ -49,9 +46,7 @@ func Test_getDataSourcePolicy(t *testing.T) {
 `,
 		},
 		{
-			// Production path: getInputVariables sets "var" as a cty.Object of
-			// resolved defaults. A no-default variable is absent from the object,
-			// so var.sid_value raises "Unsupported attribute".
+			// "var" present but no default: raises "Unsupported attribute".
 			name: "should not drop policy when scalar fields reference variables with no default (production var context)",
 			args: args{
 				currentPath:  filepath.Join("..", "..", "..", "test", "fixtures", "test_terraform_data_source_unknown_vars"),
@@ -62,8 +57,7 @@ func Test_getDataSourcePolicy(t *testing.T) {
 `,
 		},
 		{
-			// Absent var context: "var" not in inputVars at all, so var.sid_value
-			// raises "Unknown variable".
+			// "var" absent entirely: raises "Unknown variable".
 			name: "should not drop policy when scalar fields reference variables with no var context",
 			args: args{
 				currentPath:  filepath.Join("..", "..", "..", "test", "fixtures", "test_terraform_data_source_unknown_vars"),