Fix deployment?

Author: ivantha

backend/Dockerfile

@@ -88,9 +88,6 @@ USER app
 # Ensure the virtual environment is in PATH
 ENV PATH="/app/.venv/bin:$PATH"
 
-# Default port for local/dev. Platforms like Cloud Run will inject $PORT.
-ENV PORT=8000
-
 # Document the port; EXPOSE is informational for most orchestrators
 EXPOSE 8000
 

backend/app/__init__.py

@@ -22,23 +22,12 @@ async def lifespan(app: FastAPI):
     setup_logging()
     logger = get_logger("app", component="application")
 
-    # Initialize database pool with retry and timeout
+    # Initialize database pool
     from db.pool import database_pool
-    import asyncio
-
-    try:
-        # Try to connect to database with timeout
-        await asyncio.wait_for(
-            database_pool.setup(logger=logger),
-            timeout=10.0,  # 10 second timeout for database connection
-        )
-        logger.info("Database connection established successfully")
-    except asyncio.TimeoutError:
-        logger.warning("Database connection timed out during startup - continuing without database")
-    except Exception as e:
-        logger.warning(f"Database connection failed during startup: {e} - continuing without database")
-
-    # Ensure temporary directory exists
+
+    await database_pool.setup(logger=logger)
+
+    # Create tmp directories
     from core.config import settings
 
     settings.tmp_dir.mkdir(parents=True, exist_ok=True)
@@ -55,10 +44,7 @@ async def lifespan(app: FastAPI):
     yield
 
     # Shutdown
-    try:
-        await database_pool.close()
-    except Exception as e:
-        logger.warning(f"Error closing database pool: {e}")
+    await database_pool.close()
     logger.info("App shutdown complete")
 
 

backend/cloudbuild.yaml

@@ -46,7 +46,7 @@ steps:
     id: 'push-backend'
     waitFor: [ 'build-backend' ]
 
-  # Deploy backend to Cloud Run (only waits for push, not cleanup)
+  # Deploy backend to Cloud Run (waits for push to complete)
   - name: 'gcr.io/cloud-builders/gcloud'
     args:
       - 'run'
@@ -74,7 +74,21 @@ steps:
       - '--timeout'
       - '$_TIMEOUT'
     id: 'deploy-backend'
-    waitFor: [ 'push-backend' ]  # Only wait for push to complete, cleanup can continue in parallel
+    waitFor: [ 'push-backend' ]  # Wait for push to complete fully
+
+  # Verify deployment completed successfully
+  - name: 'gcr.io/cloud-builders/gcloud'
+    args:
+      - 'run'
+      - 'services'
+      - 'describe'
+      - 'ai-slop-backend'
+      - '--region'
+      - '$_REGION'
+      - '--format'
+      - 'value(status.url)'
+    id: 'verify-deployment'
+    waitFor: [ 'deploy-backend' ]  # Wait for deployment to complete
 
 # Set timeout for the entire build
 timeout: 3600s