Commit f2acced
chore(login): a11y aria-label on cancel button + bound mac PATH probe (#31)
Two small UX/perf fixes flagged by the local 3-agent reviews on PR
#27 and PR #29:
- Login button now sets `aria-label` reflecting its dual role: "Log
into <profile>" when idle, "Cancel login for <profile>" while a
login is in flight. The visible label was already updated (spinner
+ red "取消") and the `title` attribute carried the cancel hint, but
many screen readers prefer aria-label and ignore title; this makes
the dual semantics announced consistently across assistive tech.
New i18n keys `profileLoginCancelAria` / `profileLoginReadyAria`
(en + zh-CN).
- mac `suggested_codex_cli_paths` walked the entire `PATH` and
stat'd `<entry>/codex` for every component, blocking the
`get_codex_cli_status` Tauri command for seconds when PATH includes
NFS / SMB / slow drives. Now bounded by a 500 ms soft deadline:
fixed locations (Codex.app bundle, Homebrew, npm-global, etc) are
checked first since those are guaranteed-fast local stats, then the
bounded PATH walk fills in whatever remaining suggestions fit in
the deadline. Worst case: dialog still opens promptly even on a
pathologically slow PATH.
Both are pure refinements — no behavior change on the happy path.
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>1 parent c3fa8ef commit f2acced
3 files changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
257 | 266 | | |
258 | 267 | | |
259 | 268 | | |
| |||
280 | 289 | | |
281 | 290 | | |
282 | 291 | | |
| 292 | + | |
283 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
284 | 297 | | |
285 | 298 | | |
286 | 299 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
213 | 215 | | |
214 | 216 | | |
215 | 217 | | |
| |||
429 | 431 | | |
430 | 432 | | |
431 | 433 | | |
| 434 | + | |
| 435 | + | |
432 | 436 | | |
433 | 437 | | |
434 | 438 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
604 | 604 | | |
605 | 605 | | |
606 | 606 | | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
607 | 612 | | |
608 | 613 | | |
609 | 614 | | |
| |||
0 commit comments