Skip to content

Commit 2b280e6

Browse files
bkaradzic-microsoftbkaradzicCopilot
authored
Re-enable blur-cube-with-the-effect-renderer validation test (#1763)
## What Re-enables the `blur-cube-with-the-effect-renderer` Playground validation test (`#4C900K#2`) by dropping its `excludeFromAutomaticTesting` entry in `config.json`, and bumps the bundled `babylonjs` to **9.15.0** (which contains the paired engine fix) so the test actually passes in CI. Two commits: 1. Re-enable `blur-cube-with-the-effect-renderer` in `Apps/Playground/Scripts/config.json`. 2. Bump `babylonjs` to 9.15.0 in `Apps/package.json` + `Apps/package-lock.json`. Broken out of #1748 so it can merge independently: #1748 re-enables this same test alongside six single-file-`.dds` cube tests, but those six are still gated on an unmerged cube-loading TS change (BabylonJS/Babylon.js#18567), whereas this test only needs the already-merged depth-test fix. (#1748 currently still carries a duplicate `blur-cube` re-enable; that entry should be dropped there once this lands.) ## Why it passes now The test previously failed pixel comparison because the native engine ignored `depthCullingState.depthTest`, so an `EffectRenderer` fullscreen pass produced an all-black frame. That is fixed by BabylonJS/Babylon.js#18558 ("[Native] Honor depthCullingState.depthTest on the native engine"), **merged 2026-06-16 and shipped in `babylonjs` 9.15.0** — the version this PR now pins. With that fix present in the bundled engine the pass renders correctly and the test matches its reference image. ## Status - **Pin bump included; the earlier gate is resolved.** The bump to 9.15.0 (which contains #18558) is part of this PR, so the re-enable no longer depends on a separate future `babylonjs` bump. - **CI is fully green**, including every Win32 D3D11 and Ubuntu desktop job that runs the validation suite — `blur-cube-with-the-effect-renderer` validates. Ready to merge (pending review). --------- Co-authored-by: Branimir Karadzic <branimirkaradzic@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Branimir Karadzic <bkaradzic@users.noreply.github.com>
1 parent 64f545d commit 2b280e6

3 files changed

Lines changed: 42 additions & 44 deletions

File tree

Apps/Playground/Scripts/config.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2575,8 +2575,6 @@
25752575
"title": "blur-cube-with-the-effect-renderer",
25762576
"playgroundId": "#4C900K#2",
25772577
"renderCount": 20,
2578-
"excludeFromAutomaticTesting": true,
2579-
"reason": "Pixel comparison fails (more than 20% pixels differ)",
25802578
"referenceImage": "blur-cube-with-the-effect-renderer.png"
25812579
},
25822580
{

Apps/package-lock.json

Lines changed: 35 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Apps/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
"getNightly": "node scripts/getNightly.js"
1010
},
1111
"dependencies": {
12-
"babylonjs": "^9.3.4",
13-
"babylonjs-addons": "^9.3.4",
14-
"babylonjs-gltf2interface": "^9.3.4",
15-
"babylonjs-gui": "^9.3.4",
16-
"babylonjs-loaders": "^9.3.4",
17-
"babylonjs-materials": "^9.3.4",
18-
"babylonjs-serializers": "^9.3.4",
12+
"babylonjs": "^9.15.0",
13+
"babylonjs-addons": "^9.15.0",
14+
"babylonjs-gltf2interface": "^9.15.0",
15+
"babylonjs-gui": "^9.15.0",
16+
"babylonjs-loaders": "^9.15.0",
17+
"babylonjs-materials": "^9.15.0",
18+
"babylonjs-serializers": "^9.15.0",
1919
"jsc-android": "^241213.1.0",
2020
"v8-android": "^7.8.2"
2121
}

0 commit comments

Comments
 (0)