chore(hygiene): tighten test panics, error context, PSP USB lint policy (#165)

* chore(hygiene): tighten test panics, propagate error context, lint policy for PSP USB crates

Three small, behavior-preserving cleanups picked up from the pre-launch
backlog:

* Replace the `assert!(matches!(...))` + `let-else { unreachable!() }`
  test pattern with a single `let-else { panic!("expected ...", x) }`.
  The let-else already panics on mismatch, so the leading assert is
  redundant. Drops ~116 `unreachable!()` calls in non-target source
  (165 → 49) and shortens 30 test files. The `assert_text!` macro in
  oasis-terminal/src/test_helpers.rs already follows this shape; doc
  comment updated to match.

* Two test panic!() callers were discarding the underlying error: the
  text-editor SDI lookup and the radio source poll error case. Capture
  `e` so test failures print what actually went wrong.

* The four standalone PSP USB crates (`oasis-usb-vbus-psp`,
  `oasis-usb-client-psp`, `oasis-usb-debug-psp`, `oasis-usb-trace-psp`)
  declare their own `[workspace]`, so they inherit none of the parent's
  clippy policy. Add a `[lints]` section to each mirroring the workspace
  policy (`undocumented_unsafe_blocks`, `unsafe_op_in_unsafe_fn`, etc. —
  all `warn` to track the parent), so unsafe-block discipline starts
  surfacing on those builds too.

Verified locally: `cargo build --workspace --tests`,
`cargo test --workspace`, `cargo clippy --workspace -- -D warnings`,
`cargo fmt --all -- --check` all pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address AI review feedback (iteration 1)

Automated fix by Claude in response to AI review feedback.

Iteration: 1/5

Co-Authored-By: AI Review Agent <noreply@anthropic.com>

---------

Co-authored-by: AI Agent Bot <ai-agent@localhost>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: AI Review Agent <ai-review-agent@localhost>

Author: 4 people

crates/oasis-app-text-editor/src/lib.rs

@@ -569,7 +569,7 @@ mod tests {
         ] {
             let obj = sdi
                 .get(name)
-                .unwrap_or_else(|_| panic!("{name} should exist after update_sdi"));
+                .unwrap_or_else(|e| panic!("{name} should exist after update_sdi: {e:?}"));
             assert!(obj.visible, "{name} should be visible");
         }
         // Menu labels present.

crates/oasis-audio/src/radio/source.rs

@@ -1025,7 +1025,7 @@ mod tests {
                         break;
                     }
                 },
-                Err(_) => panic!("unexpected error"),
+                Err(e) => panic!("unexpected error: {e:?}"),
             }
         }
         assert_eq!(total, 100);

crates/oasis-browser/src/css/cascade/tests.rs

@@ -713,12 +713,8 @@ fn only_child_pseudo_class() {
     // Single child.
     let doc = make_doc(vec![(TagName::P, vec![])]);
     let __out = &doc.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(e) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(matching::match_pseudo_class(
         &doc,
@@ -731,12 +727,8 @@ fn only_child_pseudo_class() {
     // Multiple children.
     let doc2 = make_doc(vec![(TagName::P, vec![]), (TagName::Div, vec![])]);
     let __out = &doc2.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(e2) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(!matching::match_pseudo_class(
         &doc2,
@@ -828,12 +820,8 @@ fn hover_matches_hovered_node() {
         global_layers: None,
     };
     let __out = &doc.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(elem) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(matching::match_pseudo_class(&doc, 3, elem, "hover", &hctx));
     assert!(!matching::match_pseudo_class(
@@ -870,12 +858,8 @@ fn hover_matches_ancestor_of_hovered_node() {
     };
     // <div> (ancestor) should also match :hover.
     let __out = &doc.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(div_elem) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(matching::match_pseudo_class(
         &doc, 3, div_elem, "hover", &hctx
@@ -902,12 +886,8 @@ fn visited_matches_with_visited_url() {
         global_layers: None,
     };
     let __out = &doc.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(elem) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(matching::match_pseudo_class(
         &doc, 3, elem, "visited", &vctx
@@ -934,12 +914,8 @@ fn link_matches_unvisited_anchor() {
         global_layers: None,
     };
     let __out = &doc.nodes[3].kind;
-    assert!(
-        matches!(&__out, NodeKind::Element(_)),
-        "expected NodeKind::Element, got {__out:?}"
-    );
     let NodeKind::Element(elem) = __out else {
-        unreachable!()
+        panic!("expected NodeKind::Element, got {__out:?}");
     };
     assert!(matching::match_pseudo_class(&doc, 3, elem, "link", &vctx));
     assert!(!matching::match_pseudo_class(

crates/oasis-browser/src/forms/manager.rs

@@ -489,23 +489,15 @@ mod tests {
         mgr.toggle_checkbox(0, "remember");
         // Check the internal state directly.
         let __out = &mgr.forms[0].elements[2];
-        assert!(
-            matches!(&__out, FormElement::Checkbox { .. }),
-            "expected FormElement::Checkbox, got {__out:?}"
-        );
         let FormElement::Checkbox { checked, .. } = __out else {
-            unreachable!()
+            panic!("expected FormElement::Checkbox, got {__out:?}");
         };
         assert!(*checked);
 
         mgr.toggle_checkbox(0, "remember");
         let __out = &mgr.forms[0].elements[2];
-        assert!(
-            matches!(&__out, FormElement::Checkbox { .. }),
-            "expected FormElement::Checkbox, got {__out:?}"
-        );
         let FormElement::Checkbox { checked, .. } = __out else {
-            unreachable!()
+            panic!("expected FormElement::Checkbox, got {__out:?}");
         };
         assert!(!*checked);
     }
@@ -623,12 +615,8 @@ mod tests {
 
         mgr.select_option(fid, "size", 1);
         let __out = &mgr.forms[fid].elements[0];
-        assert!(
-            matches!(&__out, FormElement::SelectBox { .. }),
-            "expected FormElement::SelectBox, got {__out:?}"
-        );
         let FormElement::SelectBox { selected_index, .. } = __out else {
-            unreachable!()
+            panic!("expected FormElement::SelectBox, got {__out:?}");
         };
         assert_eq!(*selected_index, Some(1));
     }
@@ -661,12 +649,8 @@ mod tests {
         mgr.select_option(fid, "size", 1);
         // Should remain at 0 because index 1 is disabled.
         let __out = &mgr.forms[fid].elements[0];
-        assert!(
-            matches!(&__out, FormElement::SelectBox { .. }),
-            "expected FormElement::SelectBox, got {__out:?}"
-        );
         let FormElement::SelectBox { selected_index, .. } = __out else {
-            unreachable!()
+            panic!("expected FormElement::SelectBox, got {__out:?}");
         };
         assert_eq!(*selected_index, Some(0));
     }
@@ -859,12 +843,8 @@ mod tests {
 
         let result = mgr.handle_input(FormKey::Enter);
         let __out = result;
-        assert!(
-            matches!(&__out, FormAction::Submit(_)),
-            "expected FormAction::Submit, got {__out:?}"
-        );
         let FormAction::Submit(data) = __out else {
-            unreachable!()
+            panic!("expected FormAction::Submit, got {__out:?}");
         };
         assert_eq!(data.action, "/login");
     }
@@ -1314,12 +1294,8 @@ mod tests {
 
         let result = mgr.handle_input(FormKey::Enter);
         let __out = result;
-        assert!(
-            matches!(&__out, FormAction::Submit(_)),
-            "expected FormAction::Submit, got {__out:?}"
-        );
         let FormAction::Submit(data) = __out else {
-            unreachable!()
+            panic!("expected FormAction::Submit, got {__out:?}");
         };
         assert_eq!(data.action, "/login");
         assert!(data.fields.iter().any(|(k, v)| k == "user" && v == "test"));

crates/oasis-browser/src/forms/state.rs

@@ -569,12 +569,8 @@ mod tests {
     fn element_kind_radio_button() {
         let elem = radio("color", "red", "colors", true);
         let __out = ElementKind::of(&elem);
-        assert!(
-            matches!(&__out, ElementKind::RadioButton { .. }),
-            "expected RadioButton kind, got {__out:?}"
-        );
         let ElementKind::RadioButton { group, value } = __out else {
-            unreachable!()
+            panic!("expected RadioButton kind, got {__out:?}");
         };
         assert_eq!(group, "colors");
         assert_eq!(value, "red");

crates/oasis-core/src/dashboard/vector_icons.rs

@@ -781,12 +781,8 @@ mod tests {
         let icon = icon_for_app("altimit", &app, 0, 0, &cfg);
         // First op should use the app's color.
         let __out = &icon.ops[0];
-        assert!(
-            matches!(&__out, oasis_vector::op::VectorOp::StrokeRect { .. }),
-            "expected StrokeRect for the_world icon, got {__out:?}"
-        );
         let oasis_vector::op::VectorOp::StrokeRect { color, .. } = __out else {
-            unreachable!()
+            panic!("expected StrokeRect for the_world icon, got {__out:?}");
         };
         assert_eq!(*color, Color::rgb(255, 0, 0));
     }
@@ -923,12 +919,8 @@ mod tests {
         assert_eq!(icon.name, "the_world");
         // Inner element should be a FillPolygon (rotated rect) instead of FillRect
         let __out = &icon.ops[1];
-        assert!(
-            matches!(&__out, oasis_vector::op::VectorOp::FillPolygon { .. }),
-            "expected FillPolygon for animated the_world inner element, got {__out:?}"
-        );
         let oasis_vector::op::VectorOp::FillPolygon { points, .. } = __out else {
-            unreachable!()
+            panic!("expected FillPolygon for animated the_world inner element, got {__out:?}");
         };
         assert_eq!(points.len(), 4);
 

crates/oasis-core/src/plugin/examples.rs

@@ -331,12 +331,8 @@ mod tests {
             stderr: String::new(),
         };
         let __out = cmds.execute("hello", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert_eq!(s, "Hello, World!");
     }
@@ -359,12 +355,8 @@ mod tests {
             stderr: String::new(),
         };
         let __out = cmds.execute("hello OASIS", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert_eq!(s, "Hello, OASIS!");
     }
@@ -417,12 +409,8 @@ mod tests {
             stderr: String::new(),
         };
         let __out = cmds.execute("pclock", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert!(s.contains("plugin active"));
     }
@@ -455,23 +443,15 @@ mod tests {
         let __out = cmds
             .execute("note write todo Fix the bug", &mut env)
             .unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert!(s.contains("saved"));
 
         // Read it back.
         let __out = cmds.execute("note read todo", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert_eq!(s, "Fix the bug");
     }
@@ -495,25 +475,17 @@ mod tests {
         };
         // Initially empty.
         let __out = cmds.execute("note list", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert!(s.contains("no notes"));
 
         // Write a note and list again.
         cmds.execute("note write memo Remember to test", &mut env)
             .unwrap();
         let __out = cmds.execute("note list", &mut env).unwrap();
-        assert!(
-            matches!(&__out, CommandOutput::Text(_)),
-            "expected text, got {__out:?}"
-        );
         let CommandOutput::Text(s) = __out else {
-            unreachable!()
+            panic!("expected text, got {__out:?}");
         };
         assert!(s.contains("memo"));
     }