Skip to content

Commit dbde879

Browse files
deadlyjackAjit Kumar
andauthored
Ajit/poslish app (#2165)
* feat(settings): add promotions section and image support for list items fix(updates): correct semver version comparison logic refactor(plugin): replace rating colors with theme variables - Add fetchPromotions() to cache promotional content from API - Render cached promotions as settings items with image icons - Support item.image in settings list for inline image rendering - Fix version check to compare semver components sequentially - Add --success-text-color CSS variable and ThemeBuilder accessor - Replace hardcoded brand icon colors with inherited theme colors - Add like/like-solid icon glyphs with cache-busting font URL (?v3) - Add settings-category-discover-apps i18n string across all locales - Fix file mode on style.css (755→644) - Validate promotion icon/link_text types before rendering * fix: linting * fix(promotions): allow server to clear cached promotions and validate URL scheme - Remove data.length guard so empty [] response clears stale promotions - Validate promo.url starts with http:// or https:// before rendering --------- Co-authored-by: Ajit Kumar <dellevenjack@gmail>
1 parent ebbb804 commit dbde879

40 files changed

Lines changed: 117 additions & 52 deletions

src/components/settingsPage.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -310,14 +310,27 @@ function createListItemElement(item, options, useInfoAsDescription) {
310310
const $item = (
311311
<div
312312
tabIndex={1}
313-
className={`list-item ${item.sake ? "sake" : ""} ${item.icon ? "" : "no-leading-icon"}`}
313+
className={`list-item ${item.sake ? "sake" : ""} ${item.icon || item.image ? "" : "no-leading-icon"}`}
314314
data-key={item.key}
315315
data-action="list-item"
316316
>
317317
<span
318-
className={`icon ${item.icon || "no-icon"}`}
318+
className={`icon ${item.icon || (item.image ? "" : "no-icon")}`}
319319
style={{ color: item.iconColor }}
320-
></span>
320+
>
321+
{item.image && (
322+
<img
323+
src={item.image}
324+
alt=""
325+
style={{
326+
width: "100%",
327+
height: "100%",
328+
objectFit: "contain",
329+
borderRadius: "4px",
330+
}}
331+
/>
332+
)}
333+
</span>
321334
<div ref={$setting} className="container">
322335
<div className="text">{item.text?.capitalize?.(0) ?? item.text}</div>
323336
</div>

src/lang/ar-ye.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "اكتشف المزيد من التطبيقات",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/be-by.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "Адкрыйце больш прыкладанняў",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/bn-bd.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "আরও অ্যাপ আবিষ্কার করুন",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/cs-cz.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "Objevte další aplikace",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/de-de.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "Weitere Apps entdecken",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/en-us.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,7 @@
613613
"lsp-error-websocket-url-required": "WebSocket URL is required",
614614
"lsp-view-initialization-options": "View initialization options",
615615
"settings-category-about-acode": "About Acode",
616+
"settings-category-discover-apps": "Discover more apps",
616617
"settings-category-advanced": "Advanced",
617618
"settings-category-assistance": "Assistance",
618619
"settings-category-core": "Core settings",

src/lang/es-sv.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "Descubre más aplicaciones",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/fr-fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "Découvrir plus d'applis",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

src/lang/he-il.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@
595595
"lsp-version-line": "Version: {version}",
596596
"lsp-view-initialization-options": "View initialization options",
597597
"settings-category-about-acode": "About Acode",
598+
"settings-category-discover-apps": "גלה עוד אפליקציות",
598599
"settings-category-advanced": "Advanced",
599600
"settings-category-assistance": "Assistance",
600601
"settings-category-core": "Core settings",

0 commit comments

Comments
 (0)