Compilation error with pre-release 5.1.0

[multimeric]

Describe your problem

5.1.0 fails to compile when SYCL is false.

Environment:

• OS: MacOS (unknown version)
• MPI runtime: OpenMPI 4.1.6
• RELION version: 5.1.0
• Memory: 28GB
• GPU: M4 pro GPU

Dataset:
n/a

Job options:
n/a

Error message:

01:50:08 BIOCONDA INFO (ERR) Running apps/CMakeLists.txt...
01:50:08 BIOCONDA INFO (ERR) CMake Error at src/apps/CMakeLists.txt:515 (target_link_libraries):
01:50:08 BIOCONDA INFO (ERR)   The keyword signature for target_link_libraries has already been used with
01:50:08 BIOCONDA INFO (ERR)   the target "relion_lib".  All uses of target_link_libraries with a target
01:50:08 BIOCONDA INFO (ERR)   must be either all-keyword or all-plain.
01:50:08 BIOCONDA INFO (ERR) 
01:50:08 BIOCONDA INFO (ERR)   The uses of the keyword signature are here:
01:50:08 BIOCONDA INFO (ERR) 
01:50:08 BIOCONDA INFO (ERR)    * src/apps/CMakeLists.txt:226 (target_link_libraries)
01:50:08 BIOCONDA INFO (ERR)    * src/apps/CMakeLists.txt:378 (target_link_libraries)
01:50:08 BIOCONDA INFO (ERR)    * src/apps/CMakeLists.txt:383 (target_link_libraries)
01:50:08 BIOCONDA INFO (ERR)    * src/apps/CMakeLists.txt:388 (target_link_libraries)

Additional Context

I'm the maintainer of the relion bioconda package, and this error came up in the automated upgrade to 5.1.0.

You can view the full build log here: https://app.circleci.com/pipelines/github/bioconda/bioconda-recipes/181326/workflows/99e8353a-6e94-42a6-9150-e8e02f825b3f/jobs/333510?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary.

I note that the error (non-keyword usage of target_link_libraries) seems to still be in the 5.1.0 branch:

relion/src/apps/CMakeLists.txt

Line 515 in cb26836

target_link_libraries(relion_lib ${OpenMP_omp_LIBRARY})

[biochem-fan]

Thank you very much for your report.
It is puzzling that it used to work with 5.0, because 5.0 also contains the line.

Anyway, I added the PUBLIC keyword to the file in 5.0 and propagated it into 5.1. Could you please test again with the latest commit in the ver5.1 branch?

By the way, please note that 5.1 is still in beta testing (the 5.1.0 tag is in the draft state).

[multimeric]

It is puzzling that it used to work with 5.0, because 5.0 also contains the line.

Probably this exact code path never got hit before. In which case the question is why SYCL is now falsy. It's probably to do with MacOS-specific dependencies not being available etc

Anyway, I added the PUBLIC keyword to the file in 5.0 and propagated it into 5.1. Could you please test again with the latest commit in the ver5.1 branch?

Thanks, will do!

By the way, please note that 5.1 is still in beta testing (the 5.1.0 tag is in the draft state).

Yeah I've noted this in the title. The weird thing is that the bioconda bot tried to make a new package for a pre-release, which I don't think it should do. I will follow up with bioconda on that issue separately. I'll also delay merging a new conda package for relion until you've done a full release of 5.1.0.