[release] Add static UnRAR and Unicode copy safeguards

Squash merge local work branch onto origin/main for v1.0.19.

Highlights:

- Route disk-panel copy, move, drop, and copy-of operations through the wide snapshot builder with filters, ADS handling, rename masks, and long-path coverage.

- Preserve legacy copy safeguards for same-path targets and encrypted source/target destinations.

- Statically link the vendored UnRAR engine into salunrar.dll and remove the external unrar.dll dependency.

- Expand plugin build coverage, including FTP CMake support and release distribution population.

Author: 0xeb

cmake/sal_plugin.cmake

@@ -8,17 +8,23 @@ if(NOT DEFINED SAL_ROOT)
   include("${CMAKE_CURRENT_LIST_DIR}/sal_common.cmake")
 endif()
 
-# sal_add_plugin_lang(NAME <plugin_name>)
+# sal_add_plugin_lang(NAME <plugin_name>
+#   [SOURCE_DIR <plugin_root>]
+# )
 #   Adds the English language file (.slg) for a plugin
 #   Looks for lang/lang.rc in the plugin directory
 function(sal_add_plugin_lang)
-  cmake_parse_arguments(PARSE_ARGV 0 LANG "" "NAME" "")
+  cmake_parse_arguments(PARSE_ARGV 0 LANG "" "NAME;SOURCE_DIR" "")
 
   if(NOT LANG_NAME)
     message(FATAL_ERROR "sal_add_plugin_lang: NAME is required")
   endif()
 
-  set(PLUGIN_DIR "${SAL_PLUGINS}/${LANG_NAME}")
+  if(LANG_SOURCE_DIR)
+    get_filename_component(PLUGIN_DIR "${LANG_SOURCE_DIR}" ABSOLUTE)
+  else()
+    set(PLUGIN_DIR "${SAL_PLUGINS}/${LANG_NAME}")
+  endif()
   set(LANG_RC "${PLUGIN_DIR}/lang/lang.rc")
 
   if(NOT EXISTS "${LANG_RC}")
@@ -64,6 +70,7 @@ endfunction()
 
 # sal_add_plugin(NAME <plugin_name>
 #   SOURCES <source_files>...
+#   [SOURCE_DIR <plugin_root>]
 #   [INCLUDES <include_dirs>...]
 #   [DEFINES <preprocessor_defines>...]
 #   [LIBS <libraries>...]
@@ -77,7 +84,7 @@ endfunction()
 function(sal_add_plugin)
   cmake_parse_arguments(PARSE_ARGV 0 PLUGIN
     "NO_SHARED;NO_PCH;NO_LANG"
-    "NAME;RC;DEF;PCH"
+    "NAME;SOURCE_DIR;RC;DEF;PCH"
     "SOURCES;INCLUDES;DEFINES;LIBS"
   )
 
@@ -86,7 +93,11 @@ function(sal_add_plugin)
   endif()
 
   set(TARGET_NAME "plugin_${PLUGIN_NAME}")
-  set(PLUGIN_DIR "${SAL_PLUGINS}/${PLUGIN_NAME}")
+  if(PLUGIN_SOURCE_DIR)
+    get_filename_component(PLUGIN_DIR "${PLUGIN_SOURCE_DIR}" ABSOLUTE)
+  else()
+    set(PLUGIN_DIR "${SAL_PLUGINS}/${PLUGIN_NAME}")
+  endif()
 
   # Default PCH header
   if(NOT PLUGIN_PCH)
@@ -188,7 +199,7 @@ function(sal_add_plugin)
 
   # Build language file if it exists (unless NO_LANG is specified)
   if(NOT PLUGIN_NO_LANG)
-    sal_add_plugin_lang(NAME ${PLUGIN_NAME})
+    sal_add_plugin_lang(NAME ${PLUGIN_NAME} SOURCE_DIR "${PLUGIN_DIR}")
   endif()
 
   message(STATUS "Added plugin: ${PLUGIN_NAME}")

cmake/targets/sally_sources.cmake

@@ -15,6 +15,7 @@ set(SALLY_SOURCES
   "${SAL_SRC}/color.cpp"
   "${SAL_SRC}/common/allochan.cpp"
   "${SAL_SRC}/common/array.cpp"
+  "${SAL_SRC}/common/BuildScript.cpp"
   "${SAL_SRC}/common/handles.cpp"
   "${SAL_SRC}/common/heap.cpp"
   "${SAL_SRC}/common/messages.cpp"

doc/DEV.md

@@ -33,7 +33,7 @@ A few Altap Salamander 4.0 plugins are either not included or cannot be compiled
 
 - **PictView**: The engine `pvw32cnv.dll` is not open-sourced. Consider switching to [WIC](https://learn.microsoft.com/en-us/windows/win32/wic/-wic-about-windows-imaging-codec) or another library.
 - **Encrypt**: Incompatible with modern SSD disks and has been deprecated.
-- **UnRAR**: Missing [unrar.dll](https://www.rarlab.com/rar_add.htm) (solvable, open source).
+- **UnRAR**: RAR handling is statically linked into `salunrar.dll` from vendored [RARLAB UnRAR source](https://www.rarlab.com/rar_add.htm), which is source-available/freeware for handling RAR archives and is not GPL/OSI-free.
 - **FTP**: Missing [OpenSSL](https://www.openssl.org/) libraries (solvable, open source).
 - **WinSCP**: Requires Embarcadero C++ Builder to build.
 

doc/third_party.txt

@@ -34,7 +34,13 @@ Copyright (C) Microsoft Corporation 1993-1997
 
 === Alexander Roshal ===
 Portions of UnRAR plugin utilizes decompression library written by Alexander Roshal.
-Copyright (C) 1993-2019 Alexander Roshal
+Copyright (C) 1993-2024 Alexander Roshal
+The vendored UnRAR source is statically linked into salunrar.dll and is
+distributed under the upstream UnRAR freeware/source-available terms in
+src/plugins/unrar/unrarsrc/license.txt.
+It may be used to handle RAR archives, but may not be used to develop a
+RAR/WinRAR-compatible archiver or recreate the proprietary RAR compression
+algorithm.
 
 === Martin Prikryl ===
 Portions of WinSCP plugin licensed from Martin Prikryl.