Fix icon overlays, Unicode context menus, and localization gaps

Icon overlays (TortoiseSVN, TortoiseGit, and any other provider that supplies
its icon as a .ico file) never appeared. The loader asked ExtractIcons for two
icons in a single call with both sizes packed into one argument, which requests
two consecutive icon resources rather than one icon at two sizes. A standalone
.ico holds exactly one, so the second size came back empty and the handler was
discarded, because an overlay is only used when every size loads. (#90)

Note that Windows itself stops loading overlay handlers once roughly fifteen are
registered. On a machine with many of them, Explorer may show no overlays in the
same folder where Sally now does.

Right-clicking a file whose name contains characters outside the system ANSI code
page produced no context menu and no error at all. Menu entries are now built
from the wide filename, the containing folder is bound without narrowing its
path, and a name that cannot be resolved is skipped instead of discarding the
whole selection. (#79)

Files inside a folder whose own path contains such characters could not be opened
with Enter -- including files with plain ASCII names, because the code path was
chosen from the filename alone.

Adds Help > Report a Bug, which writes a diagnostic report describing
configuration and shell integration state, including what happened to each
registered icon overlay handler and the outcome of recent context menu commands.
Unlike the existing Task List > Break route it needs only one running instance
and does not terminate the process.

Completes localization for all ten shipped languages. Strings introduced by
earlier releases -- the Light, Dark and System theme names, the Find results save
and load commands, the Paste Shortcut failure message, and the Windows Terminal
and default shell integration -- were still shown in English in every locale.

Development builds carry the correct version again. It was pinned by cached
build configuration, so binaries reported the previous release.

Credits the people who report problems, test pre-release builds, and confirm
fixes in AUTHORS.

Author: 0xeb

AUTHORS

@@ -1,16 +1,74 @@
-== Altap Salamander Fork
+== Sally Fork
+
+Project lead and principal developer
 
 Elias Bachaalany (0xeb), 2025-2026
-  - Unicode/wide string support
-  - Long path support (32K paths)
-  - Dark mode
-  - Windows Terminal integration and shell/overlay integration
-  - WebView2-based Web Viewer and viewer modernization
-  - Plugin packaging and bundled plugin set
-  - Native ARM64 and Wine compatibility
-  - Extended translations and localization pipeline
-  - Code modernization and normalization
-  - CMake build system and release pipeline
+  - Project direction, architecture, maintenance, and releases
+  - Unicode/UTF-16 filenames and 32K long-path support across panels, file
+    operations, Find, viewers, editors, drag/drop, clipboard, history, and
+    network/UNC paths
+  - Safer destructive operations and Find-result validation, including
+    protection against lossy ANSI fallbacks
+  - Light, Dark, and System themes across the core UI and bundled plugins
+  - Windows Terminal profile discovery, default-shell selection, shell
+    extension maintenance, and expanded icon-overlay support
+  - WebView2-based Web Viewer, Markdown rendering, Unicode text decoding, and
+    viewer lifecycle and navigation fixes
+  - Bundled archive, filesystem, viewer, comparison, checksum, automation, and
+    system plugins, with dependency handling and automatic plugin discovery
+  - Native x64, x86, and ARM64 packages and Wine compatibility
+  - Maintained language packs, Translator workspaces, and a reproducible
+    localization pipeline
+  - Modern CMake builds for Sally, plugins, tools, language files, and the shell
+    extension, including MSVC and clang-cl/xwin toolchains
+  - GitHub release automation, update checks, runtime and symbol packages, and
+    release artifact validation
+  - Testable OS-abstraction boundaries, crash diagnostics, source cleanup, and
+    Czech-to-English code-comment modernization
+
+Translation contributors
+
+bellus869, 2025-2026
+  - Czech-to-English source-comment translation across the Sally core
+
+Lemi257, 2025
+  - Czech-to-English source-comment translation across dialogs, viewers,
+    worker operations, and ZIP support
+
+Acknowledgements
+
+Sally is shaped by the people who take the time to report problems, test
+pre-release builds, and confirm fixes. Thank you to:
+
+  Adamaji (Adamaji74)
+  ags1234
+  Akrotkiv
+  Martin Dařílek (darilek)
+  Eduardo G. (xmiseggs)
+  KubaDee
+  LiquidatorFX
+  Paro The Parrot (ParoTheParrot)
+  Robert Pösel (Robyer)
+  radek-sedlacik-LL
+  SelfMan
+  Patrik Švestka (tukanos)
+  Thierry Lambert (thyresias)
+  tormento
+  Vector Rilke (vectorrilke)
+
+Issues carried over from Open Salamander were originally reported by:
+
+  Lukáš Cerman (lcerman)
+  emseecz
+  Ralf Hahnloser (HahnloserR)
+  mbeilste
+  Melloware (melloware)
+  Jan Ryšavý (janrysavy)
+  vygi
+
+Bug reports, testing, translations, and focused patches from the wider Sally
+community have also shaped the project. Individual issue and commit history is
+preserved on GitHub.
 
 == Original Authors
 

cmake/git_version.cmake

@@ -4,7 +4,44 @@
 
 find_package(Git QUIET)
 
-set(SALLY_LOCAL_DEV_VERSION "1.0.23" CACHE STRING "Sally local development version base")
+# Sally local development version base.
+#
+# Deliberately NOT a CACHE entry. `set(... CACHE ...)` only applies when the entry does
+# not already exist, so once a build directory had been configured, bumping this line did
+# nothing there - the stale cached value won and every build was stamped with the previous
+# release's version. That is silent and survives rebuilds, so it is only noticed when
+# someone reads the About box.
+#
+# As a normal variable it is re-evaluated on every configure, while an explicit
+# -DSALLY_LOCAL_DEV_VERSION=x.y.z on the command line still wins because that defines the
+# variable before this file runs.
+# Sally local development version base. THIS LINE IS THE SINGLE SOURCE OF TRUTH.
+#
+# Keep it AHEAD of the newest released tag: v1.0.23 is published, so leaving it at 1.0.23
+# would stamp unreleased builds with a version already shipped.
+#
+# It is deliberately neither a CACHE entry nor merely `if(NOT DEFINED)`-guarded, because
+# both let a value cached by an EARLIER configure win, and that has now shipped wrong
+# versions twice:
+#
+#   * `set(... CACHE STRING ...)` is skipped entirely when the entry already exists, so a
+#     build directory configured before a bump kept emitting the old version forever.
+#   * `if(NOT DEFINED ...)` is satisfied by a stale cache entry just as well as by a real
+#     -D, so sibling build trees (the private test suite configures Sally sub-builds of its
+#     own) silently kept their old value.
+#
+# The second one bites harder than it looks, because configure_file below writes into the
+# SOURCE tree: every build directory shares one src/git_version.h, so whichever configured
+# last decides the version for all of them. Making this line unconditional means they all
+# agree, and the shared header stops being a race.
+#
+# If you genuinely need a different value, pass -DSALLY_VERSION_OVERRIDE=x.y.z. That is a
+# distinct name, so it cannot be confused with a leftover cache entry.
+if(SALLY_VERSION_OVERRIDE)
+    set(SALLY_LOCAL_DEV_VERSION "${SALLY_VERSION_OVERRIDE}")
+else()
+    set(SALLY_LOCAL_DEV_VERSION "1.0.24")
+endif()
 
 if(GIT_FOUND AND EXISTS "${CMAKE_SOURCE_DIR}/.git")
     # Get the latest tag

cmake/targets/sally_sources.cmake

@@ -160,9 +160,12 @@ set(SALLY_SOURCES
   "${SAL_SRC}/shares.cpp"
   "${SAL_SRC}/shellib.cpp"
   "${SAL_SRC}/shellsup.cpp"
+  "${SAL_SRC}/shellsup_diag.cpp"
   "${SAL_SRC}/shexreg.c"
   "${SAL_SRC}/shexreg_ipc_names.c"
   "${SAL_SRC}/shiconov.cpp"
+  "${SAL_SRC}/shiconov_diag.cpp"
+  "${SAL_SRC}/shiconov_icons.cpp"
   "${SAL_SRC}/snooper.cpp"
   "${SAL_SRC}/sort.cpp"
   "${SAL_SRC}/stswnd.cpp"

src/bugreprt.cpp

@@ -7,6 +7,8 @@
 #include <tlhelp32.h>
 #include "common/IEnvironment.h"
 #include "common/IRegistry.h"
+#include "shiconov_diag.h"
+#include "shellsup_diag.h"
 
 // Cross-architecture register access macros for CONTEXT structure
 #ifdef _WIN64
@@ -555,6 +557,10 @@ void CCallStack::PrintBugReport(EXCEPTION_POINTERS* Exception, DWORD ThreadID, D
     static char num[50];
     static char avbuf[MAX_PATH];
     static char nameBuf[MAX_PATH];
+    // Scratch for the shell-integration sections. Static like the rest: this runs inside a
+    // process that may already be crashing, so we do not want it on the stack. Sized for a
+    // \uXXXX-escaped long path plus the surrounding fields.
+    static char BugReportDiagBuf[4096];
 
     strcpy(buf, SALAMANDER_TEXT_VERSION);
 #ifdef _DEBUG
@@ -1478,6 +1484,77 @@ void CCallStack::PrintBugReport(EXCEPTION_POINTERS* Exception, DWORD ThreadID, D
         PrintLine(param, "", FALSE);
     }
 
+    // Shell integration: what actually happened to each registered icon-overlay handler,
+    // and to the last few context-menu interactions. These two sections exist because the
+    // TRACE_* calls in shiconov.cpp and shellsup.cpp are compiled out of Release, so this
+    // report is the only channel that reaches a reporter running a shipped build.
+    __try
+    {
+        PrintLine(param, "Icon Overlays:", FALSE);
+
+        _snprintf_s(buf, _TRUNCATE, "Config root in use: %s", ShellOverlayDiag.Header.ConfigRoot);
+        PrintLine(param, buf, TRUE);
+        _snprintf_s(buf, _TRUNCATE, "ANSI code page: %u   Registered: %d   Loaded: %d",
+                    ShellOverlayDiag.Header.AnsiCodePage,
+                    ShellOverlayDiag.Header.Registered, ShellOverlayDiag.Header.Loaded);
+        PrintLine(param, buf, TRUE);
+        _snprintf_s(buf, _TRUNCATE, "System DPI: %u   Required icon sizes: %d/%d/%d",
+                    ShellOverlayDiag.Header.SystemDpi, ShellOverlayDiag.Header.IconSizes[0],
+                    ShellOverlayDiag.Header.IconSizes[1], ShellOverlayDiag.Header.IconSizes[2]);
+        PrintLine(param, buf, TRUE);
+
+        for (int i = 0; i < ShellOverlayDiag.Count(); i++)
+        {
+            const ShellOverlayDiagRecord* rec = ShellOverlayDiag.At(i);
+            if (rec == NULL)
+                continue;
+            BugReportDiagBuf[0] = 0;
+            FormatShellOverlayDiagRecord(*rec, BugReportDiagBuf, (int)sizeof(BugReportDiagBuf));
+            _snprintf_s(buf, _TRUNCATE, "[%2d] %s", i, BugReportDiagBuf);
+            PrintLine(param, buf, TRUE);
+        }
+        PrintLine(param, "", FALSE);
+    }
+    __except (EXCEPTION_EXECUTE_HANDLER)
+    {
+        sprintf(buf, "some exception has occured...");
+        PrintLine(param, buf, TRUE);
+        PrintLine(param, "", FALSE);
+    }
+
+    __try
+    {
+        PrintLine(param, "Shell Context Menu (oldest first):", FALSE);
+        for (int i = 0; i < ShellMenuDiag.Count(); i++)
+        {
+            const ShellMenuDiagRecord* rec = ShellMenuDiag.At(i);
+            if (rec == NULL)
+                continue;
+            BugReportDiagBuf[0] = 0;
+            FormatShellMenuDiagRecord(*rec, BugReportDiagBuf, (int)sizeof(BugReportDiagBuf));
+
+            // The formatter emits several lines; PrintLine takes one at a time.
+            char* line = BugReportDiagBuf;
+            while (*line != 0)
+            {
+                char* eol = strchr(line, '\n');
+                if (eol != NULL)
+                    *eol = 0;
+                PrintLine(param, line, TRUE);
+                if (eol == NULL)
+                    break;
+                line = eol + 1;
+            }
+        }
+        PrintLine(param, "", FALSE);
+    }
+    __except (EXCEPTION_EXECUTE_HANDLER)
+    {
+        sprintf(buf, "some exception has occured...");
+        PrintLine(param, buf, TRUE);
+        PrintLine(param, "", FALSE);
+    }
+
     __try
     {
         PrintLine(param, "Panels:", FALSE);

src/consts.h

@@ -822,7 +822,10 @@ void SetClipCutCopyInfo(HWND hwnd, BOOL copy, BOOL salObject);
 void ShellAction(CFilesWindow* panel, CShellAction action, BOOL useSelection = TRUE,
                  BOOL posByMouse = TRUE, BOOL onlyPanelMenu = FALSE);
 void ExecuteAssociation(HWND hWindow, const char* path, const char* name);
-void ExecuteAssociationW(HWND hWindow, const char* path, const wchar_t* nameW);
+// Wide sibling of ExecuteAssociation. BOTH the directory and the name are wide: a folder
+// whose own path is outside the ANSI code page must reach the shell intact even when the
+// file inside it has a perfectly ordinary ASCII name.
+void ExecuteAssociationW(HWND hWindow, const wchar_t* pathW, const wchar_t* nameW);
 
 BOOL CanUseShellExecuteWndAsParent(const char* cmdName);
 
@@ -2384,8 +2387,11 @@ struct CTmpEnumData
 
 const char* EnumFileNames(int index, void* param);
 
-void ShellActionAux5(UINT flags, CFilesWindow* panel, HMENU h);
-void AuxInvokeCommand(CFilesWindow* panel, CMINVOKECOMMANDINFO* ici);
+// Both return the HRESULT from the wrapped shell call, or E_UNEXPECTED if it raised an
+// exception. Callers may ignore it, but it is the only evidence we get when a shell
+// extension refuses a command (see shellsup_diag.h and issues #13/#15/#20).
+HRESULT ShellActionAux5(UINT flags, CFilesWindow* panel, HMENU h);
+HRESULT AuxInvokeCommand(CFilesWindow* panel, CMINVOKECOMMANDINFO* ici);
 void ShellActionAux6(CFilesWindow* panel);
 
 //******************************************************************************

src/files_window_actions.cpp

@@ -5,6 +5,8 @@
 #include "precomp.h"
 
 #include "common/IEnvironment.h"
+#include "common/unicode/helpers.h"
+#include "common/unicode/PanelPathPolicy.h"
 #include "cfgdlg.h"
 #include "mainwnd.h"
 #include "usermenu.h"
@@ -280,9 +282,21 @@ void CFilesWindow::Execute(int index)
             // launch of the default context menu item (association)
             HCURSOR oldCur = SetCursor(LoadCursor(NULL, IDC_WAIT));
             MainWindow->SetDefaultDirectories(); // to ensure the launching process inherits the correct current directories
-            // Use wide version for Unicode filenames that can't be represented in ANSI
-            if (file->UseWideName())
-                ExecuteAssociationW(GetListBoxHWND(), GetPath(), file->NameW);
+
+            // Go wide when EITHER the file name or the panel path needs it. Testing only
+            // the name meant that inside a folder whose own path is outside the ANSI code
+            // page, every file took the legacy branch - including files with perfectly
+            // ordinary ASCII names, because NameW is NULL for those. That branch resolves
+            // the shell binding from the lossy CP_ACP directory, so it silently failed and
+            // Enter did nothing at all for every file in the folder.
+            //
+            // Same predicate CFilesWindow::RenameFile already uses (files_window_view_edit.cpp).
+            if (file->UseWideName() || sally::unicode::WidePathNeedsExactPreservation(GetPathW()))
+            {
+                std::wstring nameW = (file->NameW != NULL) ? std::wstring(file->NameW)
+                                                           : AnsiToWide(fileName);
+                ExecuteAssociationW(GetListBoxHWND(), GetPathW(), nameW.c_str());
+            }
             else
                 ExecuteAssociation(GetListBoxHWND(), GetPath(), fileName);
 

src/lang/texts.rc2

@@ -169,6 +169,7 @@ STRINGTABLE
  IDS_MENU_HELP_CONTEXT,      "&What is This?\tShift+F1"
 // IDS_MENU_HELP_TIP,          "&Tip of the Day"
  IDS_MENU_HELP_TASKLIST,     "Task &List..."
+ IDS_MENU_HELP_REPORTBUG,    "&Report a Bug..."
  IDS_MENU_HELP_FORUM,        "Official Support &Forum"
  IDS_MENU_HELP_ABOUTPLUGINS, "About &Plugin"
  IDS_MENU_HELP_CHECKNEWVERSION, "&Check For New Versions..."
@@ -1777,7 +1778,10 @@ IDS_BROKENFSPLUGINVERSION2, "The plugin (%s) targets broken Sally SDK version 10
  IDS_ACLNOTSUPPORTEDONTGTPATH, "Owners and permissions cannot be preserved. They are not supported\non target path (it is not NTFS volume).\n\nDo you want to continue?"
 
  IDS_BUGREPORTCNFRM_TITLE, "Report a Bug"
- IDS_BUGREPORTCNFRM_TEXT, "For bug reports or feature requests please use menu Help > Official Support Forum.\n\nUse this bug report only for sending us sensitive data or when we ask you."
+ IDS_BUGREPORTCNFRM_TEXT, "For bug reports or feature requests please use menu Help > Official Support Forum.\n\nUse this bug report only for sending us sensitive data or when we ask you.\n\nThe report describes this running copy of Sally: configuration, loaded modules, panel paths, and shell integration state. Please review it before sending.\n\nCreate the report now?"
+ IDS_BUGREPORT_WRITTEN, "The bug report has been written to:"
+ IDS_BUGREPORT_FAILED, "The bug report could not be written."
+ IDS_SHELLMENU_NOSHELLITEMS, "Windows could not provide a context menu for the selected item(s)."
 
  IDS_MSGBOXBTN_SKIP, "&Skip"
  IDS_MSGBOXBTN_SKIPALL, "S&kip All"

src/main_window_commands_help.cpp

@@ -3019,6 +3019,70 @@ MENU_TEMPLATE_ITEM AddToSystemMenu[] =
             return 0;
         }
 
+        case CM_REPORTBUG:
+        {
+            // Produce a bug report for THIS process, without crashing it.
+            //
+            // The pre-existing route to a bug report is Help > Task List > Break, which
+            // refuses to break its own process (so the user needs two Sally instances) and
+            // ends in TerminateProcess. Neither is something we can ask a bug reporter to
+            // do. PrintBugReport already supports Exception == NULL - the thread-suspending
+            // "Stack Back Trace" block is gated on Exception != NULL - so the manual case
+            // costs nothing but a file.
+            //
+            // This is the only channel that carries the shell-integration ledgers
+            // (shiconov_diag.h, shellsup_diag.h) to a user running a Release build, where
+            // every TRACE_* is compiled out.
+            if (gPrompter->AskYesNo(LoadStrW(IDS_BUGREPORTCNFRM_TITLE),
+                                    LoadStrW(IDS_BUGREPORTCNFRM_TEXT))
+                    .type != PromptResult::kYes)
+            {
+                return 0;
+            }
+
+            // Same directory salmon uses, computed directly so this works even when salmon
+            // is not running: %LOCALAPPDATA%\Open Salamander.
+            char reportPath[MAX_PATH];
+            reportPath[0] = 0;
+            if (SHGetFolderPath(NULL, CSIDL_LOCAL_APPDATA, NULL, 0, reportPath) != S_OK)
+            {
+                gPrompter->ShowError(LoadStrW(IDS_ERRORTITLE), LoadStrW(IDS_BUGREPORT_FAILED));
+                return 0;
+            }
+            int len = lstrlen(reportPath);
+            if (len > 0 && reportPath[len - 1] == '\\')
+                reportPath[len - 1] = 0;
+            lstrcat(reportPath, "\\Open Salamander");
+
+            // Directory creation goes through the interface, never Win32 directly, so this
+            // file stays out of the win32-isolation allowlist.
+            std::wstring reportDirW = AnsiToWide(reportPath);
+            if (gFileSystem != NULL && !gFileSystem->DirectoryExists(reportDirW.c_str()))
+                gFileSystem->CreateDirectory(reportDirW.c_str());
+
+            // Must end in .TXT: that is what salmon's existing scan of this directory looks
+            // for when it offers to compress and upload old reports.
+            SYSTEMTIME st;
+            GetLocalTime(&st);
+            char fileName[64];
+            _snprintf_s(fileName, _TRUNCATE, "\\Sally-report-%04d%02d%02d-%02d%02d%02d.TXT",
+                        st.wYear, st.wMonth, st.wDay, st.wHour, st.wMinute, st.wSecond);
+            lstrcat(reportPath, fileName);
+
+            if (CCallStack::CreateBugReportFile(NULL, GetCurrentThreadId(), -1, reportPath))
+            {
+                char message[MAX_PATH + 200];
+                _snprintf_s(message, _TRUNCATE, "%s\n\n%s",
+                            LoadStr(IDS_BUGREPORT_WRITTEN), reportPath);
+                gPrompter->ShowInfo(LoadStrW(IDS_INFOTITLE), AnsiToWide(message).c_str());
+            }
+            else
+            {
+                gPrompter->ShowError(LoadStrW(IDS_ERRORTITLE), LoadStrW(IDS_BUGREPORT_FAILED));
+            }
+            return 0;
+        }
+
         case CM_CLIPCOPYFULLNAME:
         {
             activePanel->UserWorkedOnThisPath = TRUE;